Deprecation: remove AssemblerBase::reset_sparsity prior to 1.5 release.

[Jan Blechta]

AssemblerBase::reset_sparsity is going to be deprecated in 1.4 release and should be removed after 1.4 release. Probably also deprecated_bool class should be removed. Affected files:

grep -r reset_sparsity dolfin/ site-packages/ demo/ test/
grep -r bool_deprecated dolfin/ site-packages/ demo/ test/

dolfin/swig/fem/pre.i
dolfin/swig/fem/post.i
dolfin/fem/AssemblerBase.h
site-packages/dolfin/fem/assembling.py

[Prof Garth Wells]

Fixes Issue #285.

→ <<cset 21a6fc735f98>>

[Jan Blechta]

1. You forgot assembling.py.

2. What about bool_deprecated in AssemblerBase.h? Shouldn't we remove this also?

[Martin Sandve Alnæs]

Please don't touch assembling.py, I'm handling that.

[Prof Garth Wells]

@blechta I fixed assembler.py in another branch (by accident).

We need to coordinate the removal of deprecated functions better. I started branches for some functions before the release (so I could merge into development branches that would not be merged into master before 1.4). Cleaning this all up with multiple developers making the same changes will be a pain.

[Martin Sandve Alnæs]

Removal of the deprecated arguments other than reset_sparsity in assembler.py needs to be done in concert with a bunch of other issues in the ufl/dolfin intersection that I've been alone at handling. If you only removed reset_sparsity that's an easy merge.

[Prof Garth Wells]

@martinal I'm happy for you to take care of it.

You haven't all on your own. See https://bitbucket.org/fenics-project/dolfin/branch/garth/test-updates-for-interface-changes.

[Martin Sandve Alnæs]

reset_sparsity in assembling.py is removed in master now. Can we close this now?

[Jan Blechta]

What about removing illogically placed AssemblerBase.h/bool_deprecated class. It can be anytime recovered when needed...

[Jan Blechta]

Fix in fix-issue-285 branch. Please, merge.

[Jan Blechta]

Both reset_sparsity and bool_deprecated are already removed.

[Prof Garth Wells]

Removing milestone: 1.5 (automated comment)