LagrangeInterpolator has unnecessary copies
Issue #490
resolved
LagrangeInterpolator
does not uses references for return types where appropriate, and as a result makes numerous necessary copies.
Comments (7)
-
-
@garth-wells, could you please be more specific? @chris_richardson, what would you prefer over the try/catch clauses?
-
@mikael_mortensen -
Function::eval
could return a value which would tell you if it was successful or not. -
@chris_richardson - Absolutely, just need to keep eval from throwing exceptions.
-
-
assigned issue to
-
assigned issue to
-
- changed status to resolved
Fixes issue
#490→ <<cset f987a6c7e5a5>>
-
- removed milestone
Removing milestone: 1.6 (automated comment)
- Log in to comment
Looks OK to me - has it been updated? There are still other things which could be better, such as the try/catch clauses, which I don't like.