Default constructor without `mpi_comm` missing in a couple of classes
Issue #691
resolved
Default constructor missing for TimeSeries
, FooFactor::create_matrix/vector
and perhaps a few others. Important for simplicity and backwards compatibility that default constructors (using mpi_comm_world()
are available.
Comments (5)
-
-
reporter ok, let's leave
create_foo
as is. Do you remember if there are other instances thanTimeSeries
that have been changed? -
Patrick has an open pull request for XDMFFile.
If users are not (necessarily) feeling a change, then we should keep the one constructor rather than having two.
-
reporter - changed status to resolved
Fix issue
#691: Default constructor withoutmpi_comm
missing in a couple of classes→ <<cset db1316248cd6>>
-
reporter - removed milestone
Removing milestone: 1.7 (automated comment)
- Log in to comment
This shouldn't be changed in low-level classes, e.g. the factories. If we add it to low-level classes, it leads to bugs down the line because it doesn't force developers to think about what the appropriate communicator is.