- changed milestone to 2016.2
missing `break;`?
Comments (7)
-
-
I agree that a
break
statement is missing.In the current implementation setting
type = norm_type::default_norm
will setksp_norm_type = KSP_NORM_PRECONDITIONED;
instead of
ksp_norm_type = KSP_NORM_DEFAULT;
However since fixing this bug will change the behavior of the method, it may be better (for both reproducibility and backward compatibility) to wait until the next major release (i.e. 2017.1) before fixing this bug.
-
Since it is an obvious bug, let's just fix it. If we state in the release notes (TM) that this bug has been fixed, users will be warned. Any objections to just fixing this? @garth-wells @blechta
-
No objection - I think we should just fix it.
-
-
assigned issue to
-
assigned issue to
-
ok I'll fix it later. I really would like to get the overdue release out.
-
- changed status to resolved
Fix issue
#784: missing break in PETScKrylovSolver::set_norm_type making norm_type::default_norm result in norm_type::preconditioned.→ <<cset faf08b85dfcf>>
- Log in to comment