missing `break;`?

[Nico Schlömer]

Looks like a missing break statement at https://bitbucket.org/fenics-project/dolfin/src/4fdebe00790a2b335fe5003aa9bd507780cf0186/dolfin/la/PETScKrylovSolver.cpp?at=master&fileviewer=file-view-default#PETScKrylovSolver.cpp-420.

[Umberto Villa]

I agree that a break statement is missing.

In the current implementation setting type = norm_type::default_norm will set

ksp_norm_type = KSP_NORM_PRECONDITIONED;

instead of

ksp_norm_type = KSP_NORM_DEFAULT;

However since fixing this bug will change the behavior of the method, it may be better (for both reproducibility and backward compatibility) to wait until the next major release (i.e. 2017.1) before fixing this bug.

[Anders Logg (Chalmers)]

Since it is an obvious bug, let's just fix it. If we state in the release notes (TM) that this bug has been fixed, users will be warned. Any objections to just fixing this? @garth-wells @blechta

[Prof Garth Wells]

No objection - I think we should just fix it.

[Anders Logg (Chalmers)]

ok I'll fix it later. I really would like to get the overdue release out.

[Anders Logg (Chalmers)]

Fix issue #784: missing break in PETScKrylovSolver::set_norm_type making norm_type::default_norm result in norm_type::preconditioned.

→ <<cset faf08b85dfcf>>