test_generic_function_attributes fails with pybind

[Jørgen Dokken]

The test test_generic_function_attributes fails with following message:

    with pytest.raises(RuntimeError):
>           e2(0, 0)
E           Failed: DID NOT RAISE <class 'RuntimeError'>

test_expression.py:432: Failed

[Jan Blechta]

This is supposed to raise through

void Function::eval(Array<double>& values, const Array<double>& x,
                    const Cell& dolfin_cell, const ufc::cell& ufc_cell) const
{
...
  dolfin_assert(values.size() == value_size_loc);
...
}

which does not work when asserts are off. That's poor error handlin g.

[Jan Blechta]

The assert shouldn't be turned into error - eval can be in a tight loop.

There used to be a check for that here in generated code, although noticed the comment Runtime checks (TODO: Better to check these when updating the value instead...).

[Jan Blechta]

Fix in jan/fix-issue-983.

[Jan Blechta]

Fix issue #983

→ <<cset fdb19280c136>>

[Jan Blechta]

The fix in branch is too complicated. Just disable the test when assertions are off. The fix in next.

[Jan Blechta]

Not yet in master

[Jan Blechta]

Fix issue #983

→ <<cset 6711e9439827>>