1. Glotzer Group Avatar Glotzer Group
  2. Analysis tools
  3. freud
  4. Issues

Hexatic Order

Issue #10 resolved
Richmond Newman created an issue

vec3<float> delta should be r_j - r_i, not r_i-r_j. This causes a sign error that then effects the angles calculated. I.e. calculate conjugate(psi6) instead of psi6.

The rmaxsq check also discards some of the calculated nearest neighbors if the initial guess of rmax was set too low, and should be removed. Also num_adjacent should also equal m_k, and not be calculated via incrementing (Unless there are still circumstances where you don't or can't have k neighbors).

Comments (10)

  2. Eric Harper

    I can fix the first one. You have to be more specific with the others (please create new more descriptive issues for each).

  3. Richmond Newman reporter

    The number of neighbors is calculated via incrementing in the code, when it should be known (I.e. set to k). It's just clutter, and a few unnecessary additions.

    The distance check against rmaxsq in the inner-loop over neighbors throws out particles unless it's set to arbitrary large at the beginning of the run.

  4. Eric Harper
    1. That was left over from a previous check (to make sure it was grabbing the correct number of neighbors). Changed.
    2. From previous legacy code, and agreed, this is an issue. Fixed.
  11. Log in to comment
Assignee
Type
bug
Priority
minor
Status
resolved
Component
–
Version
–
Votes
0
Watchers
2
Jira: the preferred issue tracker for Bitbucket. Join the team!