_freud.cpp and CMakeLists.txt
Issue #90
resolved
We should probably explicitly have _freud.cpp be the only thing we tell CMake to build inside freud/CMakeLists.txt instead of globbing. With globbing, it is possible that someone deletes _freud.cpp, successfully builds and installs freud, and gets errors when importing the module.
Comments (5)
-
-
reporter I guess in particular, in cpp/CMakeLists.txt,
file(GLOB_RECURSE PYX_CPPS ${CMAKE_CURRENT_SOURCE_DIR}/../freud/*.cpp ${CMAKE_CURRENT_SOURCE_DIR}/../freud/*.c)
should just set the value to be "${CMAKE_CURRENT_SOURCE_DIR}/../freud/_freud.cpp"
-
That makes sense, and probably explains a weird commit Jens had a few weeks back. I'll implement.
-
- changed status to resolved
Resolves Issue
#90→ <<cset 463c3a4f99e3>>
-
Resolves Issue
#90→ <<cset 463c3a4f99e3>>
- Log in to comment
So, we would end up listing every py file in the file() command, but keep the custom target?