Fix warnings in testSerializationGeometry.cpp

[Frank Dellaert]

Hi @jdong37 could you take a look on your system?

[Jing Dong]

I didn't see that warning in my GCC. Could I have the warning message?

[Frank Dellaert]

In file included from /Users/frank/git/gtsam/gtsam/geometry/tests/testSerializationGeometry.cpp:19:
In file included from /Users/frank/git/gtsam/gtsam/geometry/Point2.h:20:
In file included from /opt/local/include/boost/serialization/nvp.hpp:29:
In file included from /opt/local/include/boost/serialization/split_member.hpp:23:
/opt/local/include/boost/serialization/access.hpp:125:9: warning: delete called on 'gtsam::Cal3Unified' that has virtual functions but non-virtual
      destructor [-Wdelete-non-virtual-dtor]
        delete const_cast<T *>(t);
        ^
/opt/local/include/boost/serialization/extended_type_info_typeid.hpp:133:39: note: in instantiation of function template specialization
      'boost::serialization::access::destroy<gtsam::Cal3Unified>' requested here
        boost::serialization::access::destroy(
                                      ^
/opt/local/include/boost/serialization/singleton.hpp:106:7: note: in instantiation of member function
      'boost::serialization::extended_type_info_typeid<gtsam::Cal3Unified>::destroy' requested here
class singleton_wrapper : public T
      ^
/opt/local/include/boost/serialization/singleton.hpp:141:16: note: in instantiation of member function
      'boost::serialization::singleton<boost::serialization::extended_type_info_typeid<gtsam::Cal3Unified> >::get_instance' requested here
        return get_instance();
               ^
/opt/local/include/boost/archive/detail/oserializer.hpp:111:16: note: in instantiation of member function
      'boost::serialization::singleton<boost::serialization::extended_type_info_typeid<gtsam::Cal3Unified> >::get_const_instance' requested here
            >::get_const_instance()
               ^
/opt/local/include/boost/serialization/singleton.hpp:106:7: note: in instantiation of member function
      'boost::archive::detail::oserializer<boost::archive::text_oarchive, gtsam::Cal3Unified>::oserializer' requested here
class singleton_wrapper : public T
      ^
/opt/local/include/boost/serialization/singleton.hpp:141:16: note: (skipping 6 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
        return get_instance();
               ^
/opt/local/include/boost/archive/detail/interface_oarchive.hpp:63:23: note: in instantiation of function template specialization
      'boost::archive::basic_text_oarchive<boost::archive::text_oarchive>::save_override<const gtsam::Cal3Unified>' requested here
        this->This()->save_override(t, 0);
                      ^
/Users/frank/git/gtsam/gtsam/base/serialization.h:50:15: note: in instantiation of function template specialization
      'boost::archive::detail::interface_oarchive<boost::archive::text_oarchive>::operator<<<const gtsam::Cal3Unified>' requested here
  out_archive << input;
              ^
/Users/frank/git/gtsam/gtsam/base/serializationTestHelpers.h:38:28: note: in instantiation of function template specialization
      'gtsam::serialize<gtsam::Cal3Unified>' requested here
  std::string serialized = serialize(input);
                           ^
/Users/frank/git/gtsam/gtsam/base/serializationTestHelpers.h:56:3: note: in instantiation of function template specialization
      'gtsam::serializationTestHelpers::roundtrip<gtsam::Cal3Unified>' requested here
  roundtrip<T>(input,output);
  ^
/Users/frank/git/gtsam/gtsam/geometry/tests/testSerializationGeometry.cpp:71:10: note: in instantiation of function template specialization
      'gtsam::serializationTestHelpers::equalsObj<gtsam::Cal3Unified>' requested here
  EXPECT(equalsObj(cal6));
         ^
/Users/frank/git/gtsam/CppUnitLite/Test.h:140:9: note: expanded from macro 'EXPECT'
{ if (!(condition)) \
        ^

[Jing Dong]

I have fixed it in https://bitbucket.org/gtborg/gtsam/commits/97d60884679c139146f61b666e1f365326d33adf

I cannot check in one my side. You can close it if you think it's fine now :)