write_hrate ignored in new diagnostics

[David Dickinson]

The new diagnostics module accepts write_hrate as an input but this is not used for anything. The equivalent functionality to write_hrate = .true. from the old diagnostics is controlled by write_heating=.true. in the new diagnostics – this is confusing and likely lead to mistakes. We should probably do one of:

‌

1. Remove write_heating from the new diagnostics – this may break input files.
2. Make write_heating be write_heating = write_heating .or. write_hrate so that this is enabled if either flag is set.

Option 1 may break input files so option 2 is probably preferred.

‌

[Peter Hill]

Agree, I think it needs to be option 2. At the same time, we should make sure all inputs are mapped correctly between the two systems. This will make consolidating them much easier.

[David Dickinson]

Is this resolved for 8.1?

[Peter Hill]

No, but there is at least a warning if you set the wrong one for the particular diagnostic module you’re using.

We could set write_heating = write_heating .or. write_hrate in read_diagnostics_base_config, and then switch to using write_heating in the old diagnostics module.

[Peter Hill]

Make write_heating a synonym of write_hrate, deprecate latter

Fixes #125

→ <<cset 0f36f4610998>>

[David Dickinson]

Fixed in 8.1