[JOSS] improve tutorial notebooks
Now the wrapper works fine, a bit of feedback on the notebooks:
Tutorial 01
now hampyx
is a proper python package, can you remove
sys.path.append('../hampyx/')
from the first cell?
Down below there is a full path /home/lab/hamx/tutorials/mask_tutorial_01.fits
, it should be changed to a relative path.
Finally, I get a different orthview map at the end:
do you know if that is a problem?
Comments (5)
-
reporter -
yes, the mask map looks fine, but in the coming update I’ll make a more general mask map instead, and modify the notebook with your suggestions. The pytest is now integrated in the Bitbucket pipeline, but the current run is broken since I have to rerun the notebooks again
-
I’m getting healpy warnings in read_map dtype, although I’ve added dtype=np.float64 in the python wrapper,
please see here, https://bitbucket.org/hammurabicode/hamx/commits/ca4ff4de6243fe6bc694ce767427b5c7e886bfa8,
this is a bit annoying, have I missed something?
-
nevermind, I put a warning suppression, and now the pipeline works, a strange thing is the docker hub is not catching up with my updates so I made manual commits to the repo.
-
reporter - changed status to resolved
very nice! Love that the tutorials also work as tests.
I reran all the tutorials myself and they look fine.
- Log in to comment
Tutorial e01-e02-e03
remove
#sys.path.append('../hampyx/')
remove
matplotlib.use('Agg')
, just the line below we choose theinline
backend.