Wrong order of operations, implicit multiplication

Issue #598 closed

Pol Welter created an issue 2016-03-08

Implicit multiplication followed by parentheses is handled incorrectly.

x=123

5*x^2
= 75645

5 x^2
= 75645


5 (x)^2
= 378225

Comments (8)

Helder Correia repo owner
Ouch :) Let's not forget to add this test to the suite.
- 2016-03-08T17:49:15+00:00
Pol Welter reporter
I have pinpointed the problem: it is caused by @thadrien's Rule #2 for implicit multiplication with parentheses (starting in line 935 in evaluator.cpp, originating from 6047271). This rule is required for handling cases such as 2 (2+1). Let me see if I can do something...

Otherwise we just have to ditch that rule again...
- 2016-03-08T20:25:41+00:00
Pol Welter reporter
Just posted pull request #34. Wondering if it's actually that easy a fix. All the tests succeed at least.
- 2016-03-08T20:39:38+00:00
Helder Correia repo owner
Please include @thadrien in the PR review.
- 2016-03-08T23:26:31+00:00
Helder Correia repo owner
- changed status to resolved
Fixes issue ~~#598~~

→ <<cset 4bcbb012a43b>>
- 2016-03-09T23:23:25+00:00
Helder Correia repo owner
Merged in polwel/speedcrunch/issue-598 (pull request #34)

Fixes issue ~~#598~~

→ <<cset 9233f36c3ff5>>
- 2016-03-09T23:23:25+00:00
Helder Correia repo owner
- assigned issue to
  
  Pol Welter
- 2016-03-09T23:30:27+00:00
Helder Correia repo owner
- changed status to closed
- 2016-03-09T23:30:33+00:00
Log in to comment