improve BBL column in GDAL Metadata widget

[Andreas Rabe]

BBL (bad band multiplier list) is not a good name for the column.

As we also don’t say “Names List”, but simply “Name”, a better name would be “Bad Band”. Now, the boolean values true/false make more sense.

‌

‌

‌

[Andreas Rabe]

Also keep in minf, that we already have an band properties editor, that can manipulate the values in a raster source. Column names in both widgets should match, to not confuse the user.

‌

I’ll create a Trello card for discussing that later.

[Benjamin Jakimow]

I would agree,
but in this case BBL is a legacy term, used in ENVI headers and an abbreviation widely known in IS community.
Tip: the tooltip explains what it means

‌

[Andreas Rabe]

BBL is a legacy term, used in ENVI headers and an abbreviation widely known in IS community.
Tip: the tooltip explains what it means

I would disagree,

Yes, we support BBL specified in an ENVI header, but that is just a special case. In general, bad band multipliers are specified here, no matter what GDAL format is used:
PAM/Band/Default/bad_band_multiplier

Also see: https://enmap-box.readthedocs.io/en/latest/general/glossary.html#term-bad-band-multiplier

[Andreas Rabe]

‌

[Andreas Rabe]

Also, I would argue that an ENVI Classic user will understand, that the “Bad Band” column is showing the BBL.

[Benjamin Jakimow]

I think this needs more expertise from other users.
AFAIK we also never had a team decission on the details of https://enmap-box.readthedocs.io/en/latest/general/glossary.html#term-bad-band-multiplier (just that I mentioned we should not put this into the public docs without have a discussion on it first).
However: for medata keys which are not covered by the ENVI header format I do agree to you.
In this specific case I would prefere to use the shorter and widely known abbreviation (defacto standard) “bbl” instead of a long string. Same for “fwhm”.
Of course, the “bbl” for list indicated a plural, but this is the same for “wavelength_units”.

[Benjamin Jakimow]

The BBL column contains a single checkbox or true/false only. Using a longe names for (“bad bands”, bad bands list”) requires too much space and decreases readibility of other the colum values

[Andreas Rabe]

I think this needs more expertise from other users.
AFAIK we also never had a team decission on the details of https://enmap-box.readthedocs.io/en/latest/general/glossary.html#term-bad-band-multiplier (just that I mentioned we should not put this into the public docs without have a discussion on it first).

If I remember correctly, we both talked several times about it. And as requested, I’ll also put that into an RFC.

We can have additional meetings with other people if you like, but I definitly need a good solution for the v3.10 release. So that all the algorithms and apps already using the band-wise bad band information are still working.

‌

However: for medata keys which are not covered by the ENVI header format I do agree to you.
In this specific case I would prefere to use the shorter and widely known abbreviation (defacto standard) “bbl” instead of a long string. Same for “fwhm”.

I don’t like abbreviations too much. BBL may be confusing to non-ENVI user.

Same for “fwhm”.

Agreed, no problem with writing it out: “full width at half maximum“

‌

Of course, the “bbl” for list indicated a plural, but this is the same for “wavelength_units”.

No, you would actually say that a band is using “Nanometers”.
(But we also had that discussion in the past )

[Andreas Rabe]

The BBL column contains a single checkbox or true/false only. Using a longe names for (“bad bands”, bad bands list”) requires too much space and decreases readibility of other the colum values

I don’t like that argument.

Alright, I guess we should talk about it in detail.

BTW - I also don’t like WL and WLU

[Benjamin Jakimow]

resolves #1096, closes #1088, addresses #1095, resolves #1101, addresses #1102

→ <<cset 80696482d3e2>>