1. HUB Geomatics Lab Avatar HUB Geomatics Lab
  2. EnMAP-Box
  3. enmap-box
  4. Issues

when applying changes in the Raster Band tab of the Layer Properties, the sliders reset to their initial state

Issue #689 closed
Andreas Janz created an issue

This bug only appears in QGIS. In the EnMAP-Box it works fine.

‌

Comments (38)

  3. Andreas Janz reporter

    Not sure if we should set known bugs on hold. Maybe you are right, bugs that we can not solve right now, can be on hold.

  4. Andreas Janz reporter

    As this is only happening in QGIS, a good workaround is to use the Layer Styling, this is working as expected:

    ‌

  5. Andreas Janz reporter

    The bug is now also affecting the EnMAP-Box and not only QGIS. This Raster Band widget is now quit useless. It also looks like QGIS communitity isn’t concidering it as a Bug anymore and closed the issue:

    ‌

  6. Andreas Janz reporter

    Benjamin, can’t we really do nothing about it? Can’t you just directly update the renderer of the layer, when the user interacts with any of those widgets:

    ‌

    So the user selects the bands and just leaves the dialog by clicking on Ok and not on Apply first (which would reset the selection).

    Yes, it’s a suboptimal workaround, but at least the dialog would be useful.

  8. Benjamin Jakimow

    The widget works well in the layer styling widget, so I would’nt consider it “quite useless” at all.

  9. Benjamin Jakimow

    Anyway, seems the QGIS API has changed somehow. Needs more time to figure out why the expected band changes are not written to the raster layer.

  10. Andreas Janz reporter

    The widget works well in the layer styling widget, so I would’nt consider it “quite useless” at all.

    Yes, but note that the EnMAP-Box currently has no Layer Styling panel. The workaround I mentioned on 2021-09-24 is only available outside of the EnMAP-Box, when working in the QGIS main window.

    Also, the workaround is not really practical, because layers in QGIS and in the EnMAP-Box are not “shared” between each other. For example, I couldn’t easily use the QGIS Layer Styling panel to select spectral bands for the enmap_berlin.bsq layer opened in the EnMAP-Box.

    ‌

  11. Andreas Janz reporter

    Benjamin, is this bug related to the bug in your BitFlagRenderer plugin?: https://bitbucket.org/jakimowb/bit-flag-renderer/issues/14/bitflagrenderer-is-broken-in-qgis-320

    If so, maybe you can just directly update the renderer (like you do in the BitFlagRanderer), when the user is interacting with any of the buttons. And instead of closing the dialog via the Ok button, we use the same workaround as in the BitFlagRenderer issue and just use the Cancel button to close the dialog.

    Could that work?

  14. Andreas Janz reporter

    Sorry, but I can’t confirm that this is working now.

    ‌

    I also get an error in the console: 

    Traceback (most recent call last):
  File "D:\source\QGISPlugIns\enmap-box\enmapbox\qgispluginsupport\qps\layerconfigwidgets\rasterbands.py", line 252, in syncToLayer
    renderer = self.mLayer.renderer().clone()
AttributeError: 'NoneType' object has no attribute 'clone'

    ‌

  19. Benjamin Jakimow

    updates submodules create_plugin.py: -z skips zipfile, -p considers EMB_DEPLOY_PROFILE to install plugin to QGIS profile folder added flake8u.sh to run flake8 for uncommitted files only resolves #689 for QGIS 3.22+ (required qps submodule update)

    → <<cset 6fe11abc73a1>>

  20. Andreas Janz reporter

    I still get the error message from above. 

    Traceback (most recent call last):
  File "D:\source\QGISPlugIns\enmap-box\enmapbox\qgispluginsupport\qps\layerconfigwidgets\rasterbands.py", line 252, in syncToLayer
    renderer = self.mLayer.renderer().clone()
AttributeError: 'NoneType' object has no attribute 'clone'

    ‌

    And when opening the Layer Properties again, Python crashes:

    Traceback (most recent call last):
  File "D:\source\QGISPlugIns\enmap-box\enmapbox\qgispluginsupport\qps\layerconfigwidgets\rasterbands.py", line 252, in syncToLayer
    renderer = self.mLayer.renderer().clone()
AttributeError: 'NoneType' object has no attribute 'clone'
Traceback (most recent call last):
  File "D:\source\QGISPlugIns\enmap-box\enmapbox\qgispluginsupport\qps\layerconfigwidgets\rasterbands.py", line 415, in createWidget
    w = RasterBandConfigWidget(layer, canvas, parent=parent)
  File "D:\source\QGISPlugIns\enmap-box\enmapbox\qgispluginsupport\qps\layerconfigwidgets\rasterbands.py", line 239, in __init__
    self.syncToLayer()
  File "D:\source\QGISPlugIns\enmap-box\enmapbox\qgispluginsupport\qps\layerconfigwidgets\rasterbands.py", line 252, in syncToLayer
    renderer = self.mLayer.renderer().clone()
AttributeError: 'NoneType' object has no attribute 'clone'
Process finished with exit code -1073741819 (0xC0000005)

    ‌

  24. Benjamin Jakimow

    Can't reproduce this neither for QGIS 3.22, nor for 3.24.
    Actually the RasterBandConfigWidget should’nt show up in 3.22 at all, so you are likely working with outdatet submodules.

  27. Benjamin Jakimow

    Which branch & commit are they following? In both cases it should be the latest commit in the origin master:

    $ git submodule
+f7deeb9f30bf65eb25984f99b62e6036b9b0cee7 enmapbox/apps/lmuapps (heads/master)
+fbf6b5ab8561398630ef85828a9094bc24fe4c86 enmapbox/qgispluginsupport (heads/master)

    ‌

    $ git submodule foreach git pull
Entering 'enmapbox/apps/lmuapps'
Already up to date.
Entering 'enmapbox/qgispluginsupport'
Already up to date.

    ‌

  28. Benjamin Jakimow

    In your case, does running git pull in the EnMAP-Box repo also pull updates from the submodules?

    $ git pull
Fetching submodule enmapbox/apps/lmuapps
Fetching submodule enmapbox/qgispluginsupport
Already up to date.

    ‌

  33. Andreas Janz reporter

    Ok, now it looks good.

    So the problem was the wrong branch, right?

    From now on, I just need to pull the main repo, right?

  38. Andreas Janz reporter

    Yes, as usuall you just didn’t checkout the latests updates

    You mean the dumb submodules didn’t work properly again 😛

  39. Log in to comment
Assignee
Type
bug
Priority
major
Status
closed
Component
–
Milestone
3.9 (Hotfix)
Version
3.9
Votes
0
Watchers
2
Jira: the preferred issue tracker for Bitbucket. Join the team!