update external QPS package [ongoing task]

Issue #875 open
Andreas Janz created an issue

The EnMAP-Box depends on the external QPS package managed by @Benjamin Jakimow .

Here we list all EnMAP-Box commits that update parts of QPS and need to be transfered to QPS:

https://bitbucket.org/hu-geomatics/enmap-box/commits/f8ce540458d8
BJ: related to Issue #853 “zoom to native resolution is not working correctly”. see last issue updates for details

https://bitbucket.org/hu-geomatics/enmap-box/commits/b90203258dfda0ba6f3e8ded990d8834ec45fb1b
BJ: basically added with c8d4e14780de)

https://bitbucket.org/hu-geomatics/enmap-box/commits/8a06f371ced0
BJ: nice work, but I think it should be a bit more generic, e.g. to handle multiple raster layers.
Please report on that via https://github.com/EnMAP-Box/qgispluginsupport/issues/1

https://bitbucket.org/hu-geomatics/enmap-box/commits/fa5f1bd253c5
BJ: follow-up commit to Issue #853, see above.

https://bitbucket.org/hu-geomatics/enmap-box/commits/3c97f04bd494731b2d0eb5cf362309f50bffe0c7
BJ: follow-up commit addressing https://github.com/EnMAP-Box/qgispluginsupport/issues/1

https://bitbucket.org/hu-geomatics/enmap-box/commits/7c2a49b67666
BJ: addresses the general handling of metadata. I still like to see this solved in the QGIS API, as it is likely to be done there anyway. After what we discussed this week, it this new metadata handler still part of QPS at all?
also addressed by: https://github.com/qgis/QGIS/pull/46855

After QPS is updated, just strikethrough the corresponding bullet points from the list above.

Comments (19)

  1. Benjamin Jakimow

    Please note that the QGIS Plugin Support (QPS) repository has been moved to
    https://github.com/EnMAP-Box/qgispluginsupport (EnMAP-Box will follow to github soon)

    Please add future modifications into QPS code base by PR / merge requests on it’s master branch only

    I’ll try to check the commits described above against the QPS design / consistency rules and merge them by my own.

  2. Andreas Janz reporter

    @Benjamin Jakimow , as we discussed, committing into the EnMAP-Box repo is still fine, right?

  3. Andreas Janz reporter

    Do you still need the commit links?

    Or is this from now on taken care of with the new upstream logic from EnMAP-Box repo to QPS repo?

  4. Andreas Janz reporter

    You might commit QPS related updates in the EnMAP-Box repo if you merge them agains the qps_update (it already uses QPS as subtree.

    How would that work? I develop a new feature in a branch of my choice, and at the end I merge it into qps_update? I don’t get the idea behind it.

  5. Andreas Janz reporter

    Also, I would now stop implementing new things into QPS, until you moved it to the new location under enmapbox/qps. Just let me now when you are done.

  6. Benjamin Jakimow

    Well, as I recall it from last week we decided on moving it to the new location enmapbox/qgispluginsupport/qps, to make the entire QPS repo visible, not only the qps package in it

  7. Benjamin Jakimow

    Squashed 'enmapbox/qgispluginsupport/' changes from 697d895ef..8604ddec4

    8604ddec4 flaked files f04bccfaf spectralprocessingdialog.py writes & reads spectral setting to/from temporary files 94a92b761 spectralprocessingdialog.py write spectral setting to temporary files 95fbb2ea1 Merge branch 'write_spectral_setting' 0171ee8da python-tests.yml added releast-3_22 to test matrix cf607f050 added workaround for missing QgsFieldCalculator 9b2199131 added workaround QgsProcessingParametersGenerator.Flags() 2d9c72c6b hides QgsFieldCalculator if not available 8886405dd added repaint trigger added typechecking benchmark a60f4d101 added repaint trigger added typechecking benchmark 56afe2b3d enhances SpectralSettings added release-3_22 to test routines Signed-off-by: jakimowb benjamin.jakimow@geo.hu-berlin.de dccdef480 Spectral Processing Dialog got static window title, as algo name is shown in separate widget fixed XML read error cb6eb54b5 added QgsFieldCalculator 3b0199fd4 refactoring spectral profile plots included spectral processing dialog 03ab35255 WIP refactoring profile plot model towards using QStandardItems 0f6b2f813 addresses #1 - added SelectMapLayerDialog b1761414c addresses #1 - added LayerRendererVisualization + unit test - flaked repo 59e6a783f addresses #b902032 addresses Issue #875 improved spectral profile plotting added workaround for wavelength definition at provider level 121dcec80 added test case with different pixel resolutions resolves #853 ddd03c777 addresses #853 (QPS updates) - added test_PixelScaleExtentMapTool - re-implemented zoom-to-native resolution from QGIS\src\app\qgisapp.cpp in maptools.py f74e1a3da qgisinfo.py works without start_app speclibrasterdataprovider initialized during init.py phase 4259415eb addresses #905 : temporary profile candidate gets color from profile source panel a236b916f qps pyqtgraph - try-except itemChange

    git-subtree-dir: enmapbox/qgispluginsupport git-subtree-split: 8604ddec47b6d4add389005ec6bc3a09a8bde3fd

    → <<cset 03db28f8ba8e>>

  8. Log in to comment