isnan/isinf compilation errors on testing

[Diogo R. Ferreira]

I had this problem not only on testing_zlange.cpp but on several other files as well.

Would like to fix the issue but I can't create a PR.

[Mark Gates]

For the isnan / isinf issue, please describe your platform (OS and compiler version) and your make.inc file.

For the pull request issue, please describe what you tried to do and what happened.

To create a pull request, go to YOUR fork of MAGMA, click on "Pull Requests" in the sidebar, then "create a pull request", fill out the form, and finally "Create pull request". For instance, I would go to https://bitbucket.org/mgates3/magma to create one from my fork. Your fork needs to be readable (not private) for us to evaluate the changes.

[Diogo R. Ferreira]

Thank you, Mark. I've just submitted a PR to address this.

The issue has been observed on Ubuntu 16.04 with gcc 5.4.0.

My make.inc is based on make.inc.openblas with the following changes:

• GPU_TARGET=Pascal

• OPENBLASDIR=/usr/lib

• CUDADIR=/usr/local/cuda

[Eduardo Gonzalez]

Same issue, using Intel Compiler v2018 (update 1) on Ubuntu 16.04.

icpc -O3 -fPIC -qopenmp -DNDEBUG -DADD_ -Wall -Wshadow -DMAGMA_WITH_MKL -std=c++11 -DHAVE_CUBLAS -DMIN_CUDA_ARCH=300 -I/opt/ecrc/cuda/8.0/include -I/opt/share/intel/2018/compilers_and_libraries/linux/mkl/include -I./include -I./testing -c -o testing/testing_zlange.o testing/testing_zlange.cpp
testing/testing_zlange.cpp(156): error: identifier "isnan" is undefined
              bool nan_okay;    nan_okay    = isnan(norm_magma);
                                              ^

testing/testing_zlange.cpp(166): error: identifier "isinf" is undefined
              bool inf_okay;    inf_okay    = isinf(norm_magma);
                                              ^

compilation aborted for testing/testing_zlange.cpp (code 2)
Makefile:583: recipe for target 'testing/testing_zlange.o' failed
make: *** [testing/testing_zlange.o] Error 2

$ icpc --version
icpc (ICC) 18.0.1 20171018
Copyright (C) 1985-2017 Intel Corporation.  All rights reserved.

[Eduardo Gonzalez]

I tested in CentOS 7 and it works fine. No issue (using Intel Compiler v2018 and GCC 6.4.0). So I would guess is only an Ubuntu related problem.

[Carl Yang]

I also get this issue using Ubuntu 16.04.3 LTS using nvcc V8.0.44 and gcc 4.9.3.

[Mark Gates]

include cmath; using isnan, isinf. Should fix issue #4.

→ <<cset 227f7f0ec4de>>