[VisPyCanvas] Unreachable code in VisPyVisuals

Issue #217 resolved
Juan Pablo Caram repo owner created an issue

I found this:

class ShapeColletionVisual(CompoundVisual):
    def __init__(...):
        ....
        for m in self._meshes:
            pass
            m.set_gl_state(polygon_offset_fill=True, polygon_offset=(1, 1), cull_face=False)

        for l in self._lines:
            pass
            l.set_gl_state(blend=True)
        ...

The pass in the for loops prevents the rest of the code from ever running.

Comments (3)

  1. Denis Hayrullin

    As far as I remember, these loops can be removed. Were used in the course of the smoothing research.

  2. Log in to comment