Export Toolbars file dialog doesn't append .json file extension, so exported file doesn't appear in Import Toolbars file dialog

[Jeff Almasol]

maybe only an issue on windows? (i can't test on mac)

1. open KBar Settings > SETTINGS
2. click Export Toolbars (notice the "Save as type" shows as *.json)
3. type "foo" (no quotes), then press Enter
4. click Import Toolbars ("Files of type" filter shows as *.json)

--> file dialog doesn't show the file exported in step 2

this is because the .json extension was added. the extension should be added if the user didn't specify it.

[Rafi Khan]

Resolved #83

→ <<cset 9b787f24053b>>

[Jeff Almasol]

this doesn't look fixed in drop 9... when the save file dialog appears, the kbar.json name is initially highlighted, i just typed foobar then press Enter, and it didn't append the .json extension.

i'm on win 10 creators update.

[Rafi Khan]

I think that's the behavior of the windows file dialog box. Although... I guess I could always force a filename suffix but it seems like that's not the convention in windows as I recall. Thoughts?

[Jeff Almasol]

AE and other apps try to append the "Save As Type" extension if one doesn't exist, just to reduce confusion for the user. yes, if there's an existing "foobar" on disk and you enter "foobar", the file dialog will do its automatic "foobar already exists. Do you want to replace it?" thing, even though it'll append .aep.

also, since your "Files of type" filter list on the import side only has ".json" and doesn't have an "All Files (.)" type of entry to show files w/o extensions, my recommendation is to ensure the expected extension exists. i don't suggest adding "All Files (.*)". just make it simple for users, and try to prevent them from getting into these weird states.

[Rafi Khan]

Resolved #83

→ <<cset 144989fb3093>>