Bdd with free variable is created during propagation

[Broes De Cat]

Reproduce with 1b81495e43514522e1037b27f0a36dbb564ec866 (current master) as ./tests/satcp --gtest_filter=ModelExpansion/MXsatTest.DoesMXWithCP/38

[Bart Bogaerts]

This test is working fine with me. You should never refer to the number that gtest gives to tests since these vary from pc to pc... ;-)

[Broes De Cat]

Ah, was not aware of that :) Satstemmatology it is

[Bart Bogaerts]

Fixed issue with leafconnectors and duplicate variables

To clarify this case: suppose a leaf is P(x,x) and a connector is P(a,b). lcd should contain all data linking these two predforms we want that leaftoconnector is x-> a or x-> b, doesn't matter which and that equalities is a=b and that connectortoleaf is a->x AND b-> x Here was the mistake. This was an OR in the previous implementation.

This fixes #272

→ <<cset 5d58523c500f>>

[Bart Bogaerts]

Fixed issue with leafconnectors and duplicate variables

To clarify this case: suppose a leaf is P(x,x) and a connector is P(a,b). lcd should contain all data linking these two predforms we want that leaftoconnector is x-> a or x-> b, doesn't matter which and that equalities is a=b and that connectortoleaf is a->x AND b-> x Here was the mistake. This was an OR in the previous implementation.

This fixes #272

Also added test for this behaviour that fails even when propagation options are low

→ <<cset 7aa72ff1b47c>>

[Bart Bogaerts]

Fixed issue with leafconnectors and duplicate variables

To clarify this case: suppose a leaf is P(x,x) and a connector is P(a,b). lcd should contain all data linking these two predforms we want that leaftoconnector is x-> a or x-> b, doesn't matter which and that equalities is a=b and that connectortoleaf is a->x AND b-> x Here was the mistake. This was an OR in the previous implementation.

This fixes #272

Also added test for this behaviour that fails even when propagation options are low

→ <<cset 4e313bc7fb2b>>

[Bart Bogaerts]

Fixed issue with leafconnectors and duplicate variables

To clarify this case: suppose a leaf is P(x,x) and a connector is P(a,b). lcd should contain all data linking these two predforms we want that leaftoconnector is x-> a or x-> b, doesn't matter which and that equalities is a=b and that connectortoleaf is a->x AND b-> x Here was the mistake. This was an OR in the previous implementation.

This fixes #272

Also added test for this behaviour that fails even when propagation options are low

→ <<cset 75ce5cf3e2e7>>

[Broes De Cat]

Fixed issue with leafconnectors and duplicate variables

To clarify this case: suppose a leaf is P(x,x) and a connector is P(a,b). lcd should contain all data linking these two predforms we want that leaftoconnector is x-> a or x-> b, doesn't matter which and that equalities is a=b and that connectortoleaf is a->x AND b-> x Here was the mistake. This was an OR in the previous implementation.

This fixes #272

Also added test for this behaviour that fails even when propagation options are low

→ <<cset a64cafaff16f>>

[Bart Bogaerts]

Fixed issue with leafconnectors and duplicate variables

To clarify this case: suppose a leaf is P(x,x) and a connector is P(a,b). lcd should contain all data linking these two predforms we want that leaftoconnector is x-> a or x-> b, doesn't matter which and that equalities is a=b and that connectortoleaf is a->x AND b-> x Here was the mistake. This was an OR in the previous implementation.

This fixes #272

Also added test for this behaviour that fails even when propagation options are low

→ <<cset 21b15847f36e>>