Holy Pomanders

[Sahar Atias]

Well there's a bug atm with holy pomanders apperantly. If you take a subclass get 3rd class you get the holy pomanders, however if you decide to delete that sub and later on decide to make it again, you won't get holy pomanders anymore (and neither skills, ofcourse).

Since these items can only be in inventory (not depositable etc) then I belive best solution would be to unset the variable related to holy pomander when deleting a subclass incase a pomander cannot be found in inventory (Which means in other words that it was used for learning a skill, which will get erased anyway upon sub deletion).

[Lucas de la Torre]

Confirmed.

[bouh bouh]

this fix can work : http://pastebin.com/Zj47TSzs

[Lucas de la Torre]

Probably works but it's not a correct solution. You are adding logic of skill transfer inside the core when is located inside de datapack.

But as i said, like hotfix is ok :D Thank you!

[bouh bouh]

I had rework that fix DATA : http://pastebin.com/mghNXuKz CORE : http://pastebin.com/6YppX8xU

[HorridoJoho]

@Krunchy The patch looks clean. For my clarification:

1. ProfessionCancel is when you delete a subclass?

2. HolyPomander is an item you get when you take a subclass. That has to be removed when you delete a subclass?

Tell me a little bit about it so i undertsand how it should work.

[bouh bouh]

ProfessionCancel is called in L2PcInstance:modifySubClass This methode delete the currentSubclass and finally call addSubClass method

Yes the HolyPomander items must be deleted when you delete a subclass to prevent the storage of this items without the linked subclass. and if an HolyPomander item are missing on logout this patch will give it you back.

[Former user]

Add add listener for player class cancel Fix #1

@Patched by: @Krunchy

Provide code support for https://bitbucket.org/l2jserver/l2j_datapack/commits/a2470533796d1b864075b1ebf3303dea2880bd0e

→ <<cset f477f350081c>>