[Usual suspects] PHP Strict standards: Only variables should be passed by reference in wikiquery.php:213

[Krinkle]

At https://tools.wmflabs.org/usualsuspects/?language=commons&project=wikimedia&category=Copyright_violations&min_days=14&badoldones=Bad+Old+Ones

The page has verbose error logging enabled which means the user sees many "PHP Strict standards" errors on the page.

[ricordisamoa]

https://bitbucket.org/magnusmanske/magnustools/pull-request/11

[Magnus Manske]

Pass variable to array_pop, should fix #21

→ <<cset dc2ca1741b62>>

[Magnus Manske]

Merged in ricordisamoa/magnustools/strict (pull request #11)

Pass variable to array_pop, should fix #21

→ <<cset b49ffa578ca2>>

[ricordisamoa]

Thanks Magnus!

wikiquery.php does not emit warnings anymore, but /data/project/usualsuspects/public_html/index.php still does. They're caused by similar uses of array_pop and array_shift.

Unfortunately, the code does not appear to be published in any repository.