Gender game: Highlighting for Portuguese eats up a space

With the recent change in the highlighting method in 5bfab47, the replacement string is identical for all languages, but in the case of Portuguese, it needed a space before the span. (As the list of supported languages expands, I'd expect other languages to also have similar requirements.)

This means that currently the use of a space rather than a word boundary character (\b) at the beginning of the Portuguese regex (which is necessary because javascript doesn't recognize accented characters as word characters) results in that leading space being chopped up in the highlighted result.

The solution could be either including the space in the regex group, or having custom replacement strings for each language (or at least an overridable default).

The first approach is simpler but results in the highlight improperly including a space before the relevant word; the second is more complex but would allow for this issue (as well as future ones with other languages) to be solved cleanly.

Comments (7)