Layouting of lifelines broken
Issue #145
resolved
The layouting of lifelines has two problems:
- Lifelines that were woven don't have a LayoutElement associated. Either copy them during weaving to obtain the old location or create an "empty" one such that the position will be determined during layouting.
- When layouting lifelines, a lifeline is considered multiple times, meaning that the next x-position is increased too often.
Comments (4)
-
reporter -
reporter - changed status to resolved
Resolved issue
#145: When creating a LifelineView, create a LayoutElement if it doesn't exist yet. This can happen when the lifeline was woven from an advice. This is not ideal, but the user can then re-align the lifelines as preferred.→ <<cset 14dfdc0aa617>>
-
reporter - changed status to open
The latest commit breaks creating a lifeline the regular way, because initially there is no layout (it will be added in the next command). So a layout element is created, which triggers a notification and causes a NPE in
MessageViewView
line 657.Actually, the code to create a layout element is already there in the
build
method. -
reporter - changed status to resolved
Resolved issue
#145: Removed creating layout element on the fly inside addLifelineView.→ <<cset 0fdcef14c613>>
- Log in to comment
References issue
#145: When layouting lifelines, each lifeline is only considered once.→ <<cset 68fd5298337d>>