- edited description
Improve State Views
This a collection of several things to improve in the state views regarding to notification handling, model updates, commands etc.
createNewState
inStateMachineViewController
should add a command for setting the start state to the compound command (currently a separate command is executed before the actual command)- setting the start state is not done properly through the controller in the handler and listening to the notification (most is done in the handler directly).
RelationshipView.InvisibleRamEndBox
was made public to be able to access it inStateMachineViewHandler
. This violates the information hiding principle and has to be refactored.- tap-and-hold on the invisible end of a transition switches the "navigability", but besides the undo button becoming available (due to the commands) nothing else happens in the UI.
Comments (7)
-
reporter -
reporter - edited description
-
reporter - changed status to open
I am going to address some of the points.
-
reporter References issue #227: Added additional SetCommand for start state to CompoundCommand when creating a new state.
→ <<cset 0547d6da8a78>>
-
reporter References issue #227: Setting start state improvements: The handler only calls the controller and the view listens to the model changes and updates the old and new state (if they exist) accordingly.
→ <<cset fe2c7d7ec9cd>>
-
reporter References issue #227: Prevent changing the start state if the state is already the start state.
→ <<cset 71fcc0604ceb>>
-
reporter References issue #227: Made InvisibleRamEndBox private again. It now implements IHandled, so that in case it is contained inside a ContainerComponent its handler still processes events. The workaround in StateMachineViewHandler is therefore not necessary anymore.
→ <<cset aeea1713ef09>>
- Log in to comment