Wrong menu when going out of split view

Issue #302 resolved
Cécile Camillieri created an issue

When editing a message view we can still open the split view and add mappings. When closing the split view, the view switches back correctly to the message view, but the menu is the one for the structural view, and not for message view:

  • pressing 'Back' will switch the view back to the feature model instead of the structuralView
  • menu items that shouldn't be visible are shown

This happens because when going out of split view the menu for the structural view is loaded by default in the DisplaySceneHandler (line 205)

scene.showMainMenuButtons();

Instead we should check which mode we are in and show the corresponding menu. The back button having an incorrect behavior may be related to something a bit different though.

Comments (3)

  1. Matthias Schoettle

    Maybe at the same time we can improve the menu. I think it would make sense to move the menu out of the scene and put it into the AbstractView (or have a separate class). Then, when a view is displayed it is requested to contribute it's buttons to the menu.

  2. Log in to comment