Close multiple message option menus in MessageView view crash the app

Go to the MessageView view
Create at least 2 message between 2 Lifelines in order to get the option menu.
You can close the last opened option menu but the others can't be closed and the app crashes if you try.

You get this exception :

Exception in thread "Animation Thread" java.lang.NullPointerException
    at ca.mcgill.sel.ram.ui.views.message.MessageViewView.removeMessageView(MessageViewView.java:403)
    at ca.mcgill.sel.ram.ui.views.message.MessageViewView.notifyChanged(MessageViewView.java:898)
    at org.eclipse.emf.edit.provider.ChangeNotifier.fireNotifyChanged(ChangeNotifier.java:45)
    at org.eclipse.emf.edit.provider.ItemProviderAdapter.fireNotifyChanged(ItemProviderAdapter.java:239)
    at ca.mcgill.sel.ram.provider.InteractionItemProvider.notifyChanged(InteractionItemProvider.java:131)
    at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374)
    at org.eclipse.emf.ecore.util.EcoreEList.dispatchNotification(EcoreEList.java:249)
    at org.eclipse.emf.common.notify.impl.NotifyingListImpl.remove(NotifyingListImpl.java:713)
    at org.eclipse.emf.common.util.AbstractEList.remove(AbstractEList.java:462)
    at ca.mcgill.sel.ram.ui.views.message.handler.impl.MessageViewHandler.revertTemporaryObjects(MessageViewHandler.java:370)

Screenshot : Capture d’écran 2015-05-28 à 12.02.54.png

Talking with Matthias, the problem should happen because of the view notification is disabled when adding a temporary object (option menu) in MessageViewHandler.

Comments (4)