Advice not deleted when operation is removed
When an operation with an advice is deleted, the advice is not removed. In consequence the aspect cannot be saved because the message view has references to the deleted operation.
Comments (6)
-
-
-
assigned issue to
-
assigned issue to
-
- changed status to resolved
Resolves
#357: Removes aspect message view from affectedBy and aspect message view from aspect when a message view is deleted.Adds test case for ClassController.removeOperation where it is called.
→ <<cset aa0c7b8cd62b>>
-
Do we really want to delete the aspect message view x when the operation y that is affected by x is removed? (Maybe I misunderstood?)
-
That's what will be done now. The problem is that if operation y is removed, the aspect message view still references the operation. There's no way for the user to change this.
If that's not what we want, we might need to redesign the AMV to not reference the operation, since the operation will know that it is affected by the AMV, the AMV does not need that information as well.
-
ok. I think the solution for now is good, and we can revisit it if needed when time comes :)
- Log in to comment
I'm not sure how to handle it properly, because it is generally possible that an aspect message view applies to several message views. The problem right now is that the pointcut and the initial message of the advice has to point to a specific operation, even though that is not necessary information for weaving.