Associations often not drawn properly

[Matthias Schoettle]

There are a lot of cases where the end of an association (the arrow, composition polygon, ...) is at another location than the end of the line of the association.

Once, for example, one of the corresponding classes is clicked on, the associations are re-drawn and the association is drawn correctly.

[Matthias Schoettle]

If you enable the border around the invisible box of the association end (which allows to change the type, delete the association and change the navigability), you can see that the position of the box is wrong. And also the position of the multiplicity and role name.

Once a class is selected, the three components position is corrected.

[Matthias Schoettle]

Actually, this makes it hard to "hit" the invisible box, because it doesn't match the position of the line.

The incorrect position happens during loading of an aspect and when new associations are created (possibly also in some cases when dragging classes).

[Matthias Schoettle]

Would be nice to have :)

[Matthias Schoettle]

I tracked this bug down and it was introduced in commit 1753aca.

However, if you load Observer from that version you will not see this problem. If you use the current version of Observer (it has an additional method) it will appear.

[Matthias Schoettle]

Resolved issue #36: Reverted one change of commit 1753aca that caused this bug to occur. The from ends position needs to be updated after the to end was processed, because the to end might have changed something (the location of the from end).

Also, setCorrectPosition of the from end when processing the from end is now disabled, because this should have already been taken care of in the previous call. If this ever causes problems, it should be enabled again.

→ <<cset 8808ab119f86>>

[Matthias Schoettle]

There is still one issue left. On the attached image the invisible boxes (at the position of the ends) for the events is shown.

In the case where a straight line can be drawn, because one of the edges is alone, the other end is not updated, but the line is still drawn correctly (because the y of only one end is used).

[Matthias Schoettle]

Merged in Issue/36-misplaced-associations (pull request #86)

→ <<cset 4d13fdf>>

[Matthias Schoettle]

I identified the following problems:

At first, the class B was to the left, so that both edges on the implementation class were on its left side. Then, I moved B to the position on the screenshot and the other association was drawn incorrectly. The bottom of A and top of the implementation class are almost (pretty much) at the same y-position.

These occur when moving Y (which is located higher, over O) down. Because the ends on X are reordered, some of the associations can be drawn in a straight line, however, the position of the end which is alone on its side is not updated properly.

[Matthias Schoettle]

References #36: Adds edge case when bottomYTo and topYFrom are minimally overlapping.

Causes the edges to stay at LEFT and BOTTOM for slightly longer, otherwise, the line cannot be drawn properly.

→ <<cset 5ced45546c4a>>

[Matthias Schoettle]

References #36: Updates end location when drawing line straight.

When drawAllLines decides to draw the line straight, because one of the ends is alone on its edge, the end's location needs to be updated in order for the texts, which are drawn after the lines, to be moved to the correct position.

→ <<cset b94dcd915a1b>>

[Matthias Schoettle]

References #36: Adds back updateLayout for class views to improve association drawing in certain cases.

→ <<cset d5474f4028d3>>

[Matthias Schoettle]

Merged in Issues/36-association-updates (pull request #89)

Resolves #36 again: Association drawing updates

→ <<cset ee081f0c965a>>