Crash when reusing from unsaved aspect

[Matthias Schoettle]

The following exception occurs when reusing a concern from an unsaved aspect (due to the recent changes/improvements) when selecting the concern:

java.lang.NullPointerException
    at ca.mcgill.sel.ram.ui.components.browser.CoreFileBrowser$1.fileSelected(CoreFileBrowser.java:54)
    at ca.mcgill.sel.ram.ui.components.browser.RamFileBrowser.openFile(RamFileBrowser.java:822)
    at ca.mcgill.sel.ram.ui.components.browser.RamFileBrowser.fileItemDoubleTapped(RamFileBrowser.java:659)
    at ca.mcgill.sel.ram.ui.components.browser.RamFileBrowser.access$1(RamFileBrowser.java:648)
    at ca.mcgill.sel.ram.ui.components.browser.RamFileBrowser$FileItem$TapHandler.processTapEvent(RamFileBrowser.java:1004)

[Céline Bensoussan]

Should we save the aspect when the user tries reusing before saving ?

[Matthias Schoettle]

I don't think that's necessary. The concern is already saved, that should be enough.

[Céline Bensoussan]

Resolves #404: Get URI from concern instead of aspect

→ <<cset ec0077f12ba6>>

[Cécile Camillieri]

References #404: fix issue on Windows systems caused by URI.path() returning null

→ <<cset b31fd1dfd88a>>

[Cécile Camillieri]

Sorry to bump.

The changes seem to cause issues on Windows-based systems (I think only Windows).

In COREModelUtil.getLocalConcern(..), reusedConcernURI.path() returns null. From what I understand it's because on Windows URIs start with c:\Users.. and not \c\Users... and emf's URI doesn't recognize this as a hierarchical URI and so path() returns null.

I made a quick fix on my branch Weaver-Reexpose (changes made both in core and ram repo). I'm not sure if it's the best way to do it and if it works on Mac, that's why I did not push directly on master.

Commits:

• core: 2c4967565e0e78dcb7fd0e8fb0b99843ff0273f5
• ram: b31fd1dfd88a0c977185180aa1d9a872b197d45f

[Matthias Schoettle]

No problem.

If I understand this right, instead of createURI you use createFileURI and instead of toString() you use toFileString()?

Seems legit to me since we want to use a file anyway.

[Cécile Camillieri]

That's it. File systems are a pain :p

[Matthias Schoettle]

References #404: Fixes URI of Association concern to use file URI.

→ <<cset 90a9bc72b82a>>