Refactor StructuralViewUtil

Issue #529 resolved
Arthur Le Saint created an issue

StructuralViewUtil.java is in the gui project right now, it should not.

Moving the class to a utility package somewhere else is not trivial as one of it's function uses RamApp.java. This will cause a major circular dependency when the class is moved.

This issues is about solving these dependency issues, move misplaced code and refactor some function so it won't use RamApp.getActiveStructuralView() anymore.

Comments (8)

  1. Arthur Le Saint reporter

    References #529: StructuralViewUtil has been moved

    • Circular dependency were solved
    • StructuralViewUtil is now in ram.utils
    • RamApp.getActiveStructuralView() is no longer called where it shouldn't
    • RamModelUtils in gui.utils is now PrettyPrinterUtils
    • 3 functions in PrettyPrinterUtils still needs to be moved out

    → <<cset e99ee1101051>>

  2. Arthur Le Saint reporter

    References #529: Refactor createParameter function

    Changed createParameter in the controller. Moved aux function to StructuralViewUtil. Moved two functions out of PrettyPrinterUtil. Only getExistingSubTypes is left to move out

    → <<cset 6947e918f1b5>>

  3. Arthur Le Saint reporter

    References #529: Extra refactoring by changing how getChoiceofValues is done

    Using this issue to keep the refactoring going, getChoiceOfValues in the OperationItemProvider now uses already implemented function in RAMInterfaceUtil

    → <<cset 8e4e3eb56841>>

  4. Log in to comment