/gethead giving same persons head infinitly

Issue #387 resolved
Former user created an issue

after banning someone /gethead always lists you as having one head and gives you a head named " 's "

Comments (10)

  1. Anna Bakker

    Looks like this is caused by you banning an empty string, and instead adding the username of who you were meant to ban as part of the note. Probably caused by adding an extra space after /ban or somewhere in the ban command.

    07:10 <@Anna> !why ""
    07:10 <@McObot> (MCS) * By treepuncher755: __mysterious__  broke a sign on a path close to spawn
    07:10 <@McObot> (MCS) * By treepuncher755: rawpie2 using world downloader at spawn
    

    Note that using !why in irc on anything that isn't a valid character for usernames (such as "" or - or \) just gets the ban reason for the ban on that user, which doesn't actually exist as a minecraft user.

  2. Anna Bakker

    Other notes on the same player id:

    37145   2017-02-11 19:36:10     66092   107921  3       rawpie2 using world downloader at spawn
    37129   2017-02-11 18:17:48     66092   107921  3       __mysterious__  broke a sign on a path close to spawn
    36941   2017-02-09 21:38:43     66092   107921  1       xxtgpxx3200  logged when confronted by staff
    36597   2017-01-29 15:27:52     66092   107921  1       jochemancoole_2000 broke a torch along a path near spawn
    34936   2016-07-25 13:14:58     66092   103034  1       BasilTom he knows the rules of the server
    34784   2016-07-21 22:44:37     66092   103034  2       Spongebobthe3rd broke some quarts and redstoneblock cause he was exploring
    29184   2015-05-19 08:04:52     66092   54034   2       xxxjonas2000xxx Griefed glass when new. Explained rules.
    
  3. Anna Bakker

    Some of these notes are duplicates, probably from players who noticed it didn't get added correctly then tried again without a space in the command. I have cleaned up the notes, removing duplicates and moving ones to the correct usernames.

    This should resolve this specific issue. But an issue should be posted on the issue tracker for the /note command.

  4. Anna Bakker

    I've also removed all the blank lines in your banheadsclaimed file caused by using /gethead on that empty username.

  5. Riot

    Is this issue actually resolved by fixing the gethead script so it deals with invalid ban content correctly? If not, it isn't really resolved, you've just dealt with a symptom of it...

  6. Anna Bakker

    Added a check for if this happens again, so that it doesn't give empty username heads continuously. Not going to make it try to fix up the notes or anything though as that could cause duplicates or other issues. Instead the /ban and /note commands should be made to remove extra spaces after the command and before the username so that this doesn't happen.

  7. Log in to comment