Build instructions for mac shoudl be adjusted,...
to avoid: 'Could NOT find NUMA (missing: NUMA_ROOT_DIR NUMA_INCLUDE_DIR NUMA_LIBRARY)' when running ./make-Makefiles.bash
Comments (7)
-
-
reporter if libnuma isn't present what will --pools do?
-
with no libnuma, libx265 only sees one NUMA node with all hardware threads. In this case, --pools acts much like --threads did except for the 0 & 1 special cases. The pool threads are not given affinity for their socket, so the O/S may move them around (though in practice it rarely does). If your machine has only one socket, then there really is no difference. If your machine is multi-socketed, then having one pool instead of a pool per socket means you lose the work-isolation.
-
doc: document behavior of POSIX builds without libnuma (refs
#117)→ <<cset 0f85153181a8>>
-
Steve: Maybe you want to add that, on Windows one need to compile against Windows 7+ to get the NUMA API. With default compiling options it compiles against Windows Vista API which will (accidentally) disable NUMA function.
-D_WIN32_WINNT=_WIN32_WINNT_WIN7
-
Really? I didn't realize that. We only specify _WIN32_WINNT if you specifically want the binary to be XP compatible. Is the default windows target specific to compiler version or the host O/S version?
I've noted this in the docs locally, will push later
-
- changed status to resolved
we've updated the docs and changed the default target O/S for Windows
- Log in to comment
this is just a harmless warning, like being unable to find the visual leak detector on Windows. it will still build and run without libnuma