'--pools *' fails with 'x265 [warning]: extra unused command arguments given <avisynth.dll>'

[Selur]

'--pools ' fails with 'x265 [warning]: extra unused command arguments given <avisynth.dll>' but '--pools ,' and '--pools' (without parameters) works fine. -> As I understood it, '--pools', '--pools ' should do the same and should both be valid.

[Steve Borho]

--pools always expects arguments. If you want default pools it's best to leave it unspecified. It you must specify it, you're better off with '--pools=*' or '--pools=""'. '--pools' without parameters should be barfing in getopt().

this must be something odd in the way avisynth is splitting the command line and calling x265_param_parse()

[Selur]

somehow the '' got lost, '--pools ' (with a star) failed here!

[Lu Xinyue]

This is interesting. The only situation I can think of is that you are using a shell that expands your star into files automatically.

Eg. if you have files a avisynth.dll b in the directory, and you specify --pools *, it expands your command line into --pools a avisynth.dll b which leads to the error message extra unused command arguments given <avisynth.dll>.

Just my guess though.

[Steve Borho]

yes, good guess.

[Selur]

yup, I guess that's it. So no using --pools * on Windows?

[Lu Xinyue]

(Read your reply but can't see it here. It's flagged as spam)

You can use * on windows, you can try wrapping it in single quotes like --pools '*'

[Selur]

Thanks using '*' works, but it should also be mentioned somewhere in the docs.

[Selur]

Thanks that works fine.

[Lu Xinyue]

OK I think this needs to be either recorded in the doc, or changed to other symbol to avoid shell auto expanding.

[Steve Borho]

doc: clarify that --pools strings might need shell escaping (closes #121)

→ <<cset cd7d2f5c4d97>>