detect512 is needed on all architectures
Issue #442
resolved
In the x265-2.9 release, the definition of detect512 is inside an #if X265_ARCH_X86 conditional in common/cpu.cpp; however, this function is called on all architectures in common/quant.cpp, so x265 fails to link on my ARMv8 build machine.
The attached patch just moves the definition outside the conditional. A better alternative might be to only use detect512 on platforms where it could potentially return true.
Comments (2)
-
-
- changed status to resolved
fix Issue
#442: linking issue on non x86 platform→ <<cset 471726d3a046>>
- Log in to comment
I have this same problem when linking x265-2.9 on my old 32-bit PowerPC Macintosh (running OpenBSD/macppc). The patch from Adam Sampson fixes the linker error. Thank you for sharing the patch. I see that Debian uses this patch, and I will suggest this patch to OpenBSD.
I only know that I can build x265 with this patch. I don't know whether the built x265 can encode or decode video.