- changed milestone to 1.42.0
OpenXML Filter: DrawingML text line break repositioning on merge causes some documents to become corrupted
Issue #1058
resolved
When the filter parameter bPreferenceAddLineSeparatorAsCharacter.b=true and there is a a:p>a:br in a document, it is written back as a:p>a:r>a:br. This causes the repairing dialogue to appear if additional formatting is applied to text before or after a:br.
For instance, if there is a PPTX document with the following UI:
it can be represented after round-tripping as:
Here are the slide parts differences:
Furthermore, as it was noted, if extra formatting is involved, merged documents can’t be opened correctly by PowerPoint.
For more information please refer to the attached documents.
Comments (11)
-
reporter
-
Can confirm this. We have encountered this in production several times.
Currently worked around with
bPreferenceAddLineSeparatorAsCharacter.b=false -
reporter
@Alessandro Falappa , thanks for the confirmation!
A related pull request #517 was opened. I can add you as a reviewer then.
-
reporter
@Alessandro Falappa , for some reasons it is not allowed - “Alessandro Falappa is not a member of this workspace and cannot be added to this pull request”. Sorry.
-
I could merge the PR in my local branch and let you know, but it could take a while, better proceed with the standard workflow.
Otherwise I will test it once merged and report back.
-
I think we might need to add Alessandro to the Developers group for the project to be able to assign him as a reviewer.
-
reporter
@Chase Tingley , thanks for the hint!
@Alessandro Falappa , does it sound practical for you? I think @ysavourel could add you to the project group if you are OK with this.
-
reporter
- changed status to resolved
The pull request #517 was merged.
-
@Denis Konovalyenko no problem from my side!
-
reporter
@Alessandro Falappa , thanks for replying!
@ysavourel , do you think we can add @Alessandro Falappa to the project workspace? Is there anything else we should take care of in this regard?
-
@Denis Konovalyenko I can confirm this fix is effective, I have tested it using Okapi Dev in our product!
- Log in to comment
