OpenXml filter fails integration tests after PR #947 merge

[jhargrave-straker]

Integration Roundtrip tests fail for these files.

xliff comparison are probably OK as the filter changed - just need to update the golden xliff files.

[ERROR] Errors:
[ERROR] RoundTripOpenXmlIT>EventRoundTripIT.runTest:91 » OkapiTest quickparts_fields_2.docx
[ERROR] net.sf.okapi.xliffcompare.integration.OpenXmXliffCompareIT.openXmlXliffCompareFiles
[ERROR] Run 1: OpenXmXliffCompareIT>XliffCompareIT.runTest:63 » Okapi EndGroup.docx
[ERROR] Run 2: OpenXmXliffCompareIT>XliffCompareIT.runTest:63 » Okapi offce_2013_big.docx
[ERROR] Run 3: OpenXmXliffCompareIT>XliffCompareIT.runTest:63 » Okapi big.docx
[ERROR] Run 4: OpenXmXliffCompareIT>XliffCompareIT.runTest:63 » Okapi MissingPara.docx
[ERROR] Run 5: OpenXmXliffCompareIT>XliffCompareIT.runTest:63 » Okapi quickparts_fields_2.docx

‌

[jhargrave-straker]

@Chase Tingley FYI just wanted to make sure you were aware of the issue.

More detail. For this particular test the aggressive code cleanup is not enabled.

quickparts_fields_2.docx. The difference between the original and merged file is an inline code where the bold tag is removed:

[ERROR] n.s.o.c.filters.FilterTestDriver - Code type difference: x-italic;bold;color:000000; vs x-italic;color:000000; 

‌

[Denis Konovalyenko]

@jhargrave-straker thank you for the heads-up! I am looking into this.

[jhargrave-straker]

There are other failing files with similar problems - but were added to addKnownFailing. Looks like a problem with merge - but not sure why some files magically loosing inline tags. Anyway here are the other files:

[INFO] n.s.o.r.i.RoundTripOpenXmlIT - TestDako2.docx 
[ERROR] n.s.o.c.filters.FilterTestDriver - Code type difference: x-smartTag; vs x-smartTag;bold; 

[INFO] n.s.o.r.i.RoundTripOpenXmlIT - big.docx 
[ERROR] n.s.o.c.filters.FilterTestDriver - Number of codes difference: 21 vs 22
 1=[<hyperlink1>, </hyperlink1>, <run2>, </run2>, <tags3/>, <tags4/>, <run5>, <hyperlink6>, </hyperlink6>, <hyperlink7>, </hyperlink7>, <hyperlink8>, </hyperlink8>, </run5>, <run9>, <hyperlink10>, </hyperlink10>, </run9>, <tags11/>, <tags12/>, <tags13/>]
 2=[<hyperlink1>, </hyperlink1>, <run2>, </run2>, <tags3/>, <tags4/>, <run5>, <hyperlink6>, </hyperlink6>, <hyperlink7>, </hyperlink7>, <hyperlink8>, </hyperlink8>, </run5>, <run9>, <hyperlink10>, </hyperlink10>, </run9>, <tags11/>, <tags12/>, <tags13/>, <tags14/>] 

 [INFO] n.s.o.r.i.RoundTripOpenXmlIT - offce_2013_big.docx 
[ERROR] n.s.o.c.filters.FilterTestDriver - Number of codes difference: 21 vs 22
 1=[<hyperlink1>, </hyperlink1>, <run2>, </run2>, <tags3/>, <tags4/>, <run5>, <hyperlink6>, </hyperlink6>, <hyperlink7>, </hyperlink7>, <hyperlink8>, </hyperlink8>, </run5>, <run9>, <hyperlink10>, </hyperlink10>, </run9>, <tags11/>, <tags12/>, <tags13/>]
 2=[<hyperlink1>, </hyperlink1>, <run2>, </run2>, <tags3/>, <tags4/>, <run5>, <hyperlink6>, </hyperlink6>, <hyperlink7>, </hyperlink7>, <hyperlink8>, </hyperlink8>, </run5>, <run9>, <hyperlink10>, </hyperlink10>, </run9>, <tags11/>, <tags12/>, <tags13/>, <tags14/>] 

[INFO] n.s.o.r.i.RoundTripOpenXmlIT - DiamondClarity_4Cs Education Source.docx 
[ERROR] n.s.o.c.filters.FilterTestDriver - Code type difference: x-link; vs x-link;color:0000FF;underline:single; 

[INFO] n.s.o.r.i.RoundTripOpenXmlIT - Conference_Talk.pptx 
[ERROR] n.s.o.c.filters.FilterTestDriver - Code type difference: x-underline:sng; vs x-bold;underline:sng; 

‌

[jhargrave-straker]

To get the build to pass I have added quickparts_fields_2.docx to addKnownFailing and updated the golden xliff files.

[Denis Konovalyenko]

Pull request #650 was merged.