- changed milestone to 1.45.0
-
assigned issue to
Itegration tests: Okapi: The alternate gold file support
This is a follow-up for pull request #650.
Chase Tingley
As we accumulate more cases where we have known failing files in the integration tests, it might be worthwhile to expand the integration test framework to allow addKnownFailingFile
to specify an alternate gold file to compare to instead of the roundtripped version.
Denis Konovalyenko
As far as I remember, the proposed comparison with gold files has been a standard practice for some filters, especially the Open XML one. So, I am OK with following this approach in the Okapi integration tests as well.
Jim Hargrave Work
I think having the ability to specify an alternate golden file is a good idea. I know in some cases roundtrip doesn’t produce an exact version of the original. I’ve tried to compensate for this by adding several test parameters like ignore whitespace, ignore skeleton etc…
The only downside is that we will have another gold file to maintain. But if we keep the number small it is worth it IMHO.
Comments (3)
-
reporter -
reporter A related pull request #659 was opened.
-
reporter - changed status to resolved
Pull request #659 was merged.
- Log in to comment