Merging into a csv will not surround strings with a text qualifier

[Former user]

Original [issue 187](https://code.google.com/p/okapi/issues/detail?id=187) created by kucharczyk.lu... on 2011-09-19T13:59:18.000Z:

What steps will reproduce the problem? 1. Generate OmegaT package from a csv file with comma as a delimiter 2. Put a comma in a text segment in OmegaT 3. Merge it back

What is the expected output? What do you see instead? The resulting csv should have the value surrounded by a text qualifier as not to divide the string into two values. However, the resulting csv will not have the value surrounded by a text qualifier, thus resulting in separating the value into multiple values.

What version of the product are you using? On what operating system? Rainbow 6.0.1.3 on Windows 7 64/bit.

Please provide any additional information below. This can be amended by putting the surrounding quotes around the text manually in OmegaT, but I \_think\_ that this should be accounted for during the merging process.

[Former user]

Comment [1.](https://code.google.com/p/okapi/issues/detail?id=187#c1) originally posted by @ysavourel on 2011-09-19T14:05:29.000Z:

What filter (and configuration) are you using to create the OmegaT project? Table Filter or something else?

Thanks -ys

[Former user]

Comment [2.](https://code.google.com/p/okapi/issues/detail?id=187#c2) originally posted by kucharczyk.lu... on 2011-09-19T14:13:24.000Z:

I am using a custom table filter, configuration as can be seen on an attached screenshot. Hopefully that's that you've been asking for.

[Former user]

Comment [3.](https://code.google.com/p/okapi/issues/detail?id=187#c3) originally posted by @ysavourel on 2011-09-19T14:26:01.000Z:

Yes, that was what I was looking for.

Sergei: That one is probably for you.

[Former user]

Comment [4.](https://code.google.com/p/okapi/issues/detail?id=187#c4) originally posted by @ysavourel on 2011-09-19T15:52:33.000Z:

I created a test file test1.txt (attached), filtered it with okf\_table@ copy-of-csv.fprm parameters, and created a OmegaT package in Rainbow.

After "translation" in OmegaT (target test1.txt.xlf) and merging in Rainbow, the final test1.out.txt looks good.

[Former user]

Comment [5.](https://code.google.com/p/okapi/issues/detail?id=187#c5) originally posted by kucharczyk.lu... on 2011-09-20T08:44:57.000Z:

I am not sure where the problem is, then, since it didn't add the text qualifier automatically (just tested again).

[Former user]

Comment [6.](https://code.google.com/p/okapi/issues/detail?id=187#c6) originally posted by @ysavourel on 2011-09-20T10:32:08.000Z:

Just to make sure: the table filter is not auto-adding qualifiers that are not present in the source text. Only if they are in the source, they will be present in the target.

The two-way filters of Okapi only replace translated content, and are not allowed to add elements like qualifiers.

[Former user]

Comment [7.](https://code.google.com/p/okapi/issues/detail?id=187#c7) originally posted by kucharczyk.lu... on 2011-09-20T11:33:18.000Z:

Aha! As I said in the initial post, I though that this should be handled by the filters, because usage of commas (which are common in written text, as you'd surely aqree) will break the resulting document. Do you think it could be added as a checkbox option? My translation package has about 5000 segments and checking manually whether the text qualifiers are present whenever there is a comma in the target text is a chore, to say the least.

[Former user]

Comment [8.](https://code.google.com/p/okapi/issues/detail?id=187#c8) originally posted by @ysavourel on 2011-09-20T11:45:52.000Z:

I will need to discuss the possible implementation with the developers' group.

[Former user]

Comment [9.](https://code.google.com/p/okapi/issues/detail?id=187#c9) originally posted by @ysavourel on 2011-09-20T15:29:39.000Z:

Committed the enhancement. Affects the okapi-core and okapi-filter-table projects in the repository. Needs more testing.

[Former user]

Comment [10.](https://code.google.com/p/okapi/issues/detail?id=187#c10) originally posted by @ysavourel on 2011-09-20T17:08:08.000Z:

The latest snapshot (http://okapi.opentag.snapshots) has the fix. Testing welcome...

[Former user]

Comment [11.](https://code.google.com/p/okapi/issues/detail?id=187#c11) originally posted by kucharczyk.lu... on 2011-09-21T08:24:51.000Z:

I hope I'm not doing anything wrong, but I haven't notice any change. Version of Rainbow is 6.0.14-SNAPSHOT.

[Former user]

Comment [12.](https://code.google.com/p/okapi/issues/detail?id=187#c12) originally posted by kucharczyk.lu... on 2011-09-21T13:09:45.000Z:

Confirming it works as intended with the latest snapshot.