QualityChecker TARGET_SAME_AS_SOURCE for same language

[Former user]

Original [issue 220](https://code.google.com/p/okapi/issues/detail?id=220) created by mihn... on 2012-04-17T18:11:03.000Z:

Steps to reproduce: 1. Validate a bilingual file (ie XLF) file that contains translation from en to en-GB (or fr to fr-CA, and so on) 2. TARGET\_SAME\_AS\_SOURCE errors

Not all segments need to be updated in these kind of scenarios, so this adds a lot of noise.

Using m16 on Windows 7

Attached test file (sameLanguage.properties.xlf) and fix.

Please let me know how to submit the fixes to make your life easier. Patches generated by git-diff? Or the way I did it until now (old file + new file)?

Thank you, Mihai

[Former user]

Comment [1.](https://code.google.com/p/okapi/issues/detail?id=220#c1) originally posted by @ysavourel on 2012-04-18T15:44:31.000Z:

We may need to have this as an option (maybe the default). I'll check with the team.

As for how to submit fixes: simple ones like this are fine with the old+new files. We're still stumbling a bit with Git, but more complex fixes would be certainly better as patches.

[Former user]

Comment [2.](https://code.google.com/p/okapi/issues/detail?id=220#c2) originally posted by mihn... on 2012-04-18T19:15:12.000Z:

Thank you.

If there is a discussion, maybe something to bring up is making sameLanguageAs a bit smarter. For instance zh-TW and zh-HK are "the same language (at the same level as fr-FR and fr-CA are "the same"), but zh-TW and zh-CN are not "the same"

Things can be messier: az-IR and az-AZ are not "the same" (using Latin script in AZ, Arabic script in IR). Or "no" (deprecated) and "nb"? Do we care? Is that pushing it too far? Do we want to support language-script-region (if not the whole BCP 47)?

[Former user]

Comment [3.](https://code.google.com/p/okapi/issues/detail?id=220#c3) originally posted by mihn... on 2012-05-14T06:27:20.000Z:

I have added the changes to make this configurable and also expose the setting thru the UI (as a sub-option to "Warn if a target segment is the same as its source").

The default is false (don't check for the same language), but feel free to change it if you think that would be better.

And of course you can do any changes you think are necessary, without asking :-)

Thank you, Mihai

[Former user]

Comment [4.](https://code.google.com/p/okapi/issues/detail?id=220#c4) originally posted by @ysavourel on 2012-05-14T12:00:03.000Z:

Thanks Mihai. I'll try to integrate this in the dev branch as soon as possible.

[Former user]

Comment [5.](https://code.google.com/p/okapi/issues/detail?id=220#c5) originally posted by @ysavourel on 2012-05-14T15:06:53.000Z:

Thanks for the patch Mihai. It should be in the next snapshot, just after I rebuild/test all.