Wrong attribute in TMX filter getTypeAttribute() method
Issue #345
resolved
Original issue 345 created by @ysavourel on 2013-06-27T05:31:16.000Z:
The TMX filter method getTypeAttribute() is looking for a "lang" attribute, instead of "type".
I didn't fix the issue because this seems to cause some test error in the round-trip test cases.
I've also added a getAttribute(String localName) that we can probably share now that several attributes are looked up. BTW: it looks like an expensive way to read an attribute. Maybe that can be optimized.
Comments (2)
-
Account Deleted
-
Account Deleted
- changed status to resolved
Comment 2. originally posted by @fliden on 2013-06-27T19:22:30.000Z:
- Log in to comment
Comment 1. originally posted by @fliden on 2013-06-27T19:19:17.000Z:
Wow, thanks for catching that. What's worse is that the attributes on the <hi> elements were stripped out. The round-trip comparison didn't catch that. Seems it compares the type of the code but not the rawText.