Cannot register an inner class as IEditorDescriptionProvider
Original issue 347 created by and...@spartansoftwareinc.com on 2013-06-28T21:15:37.000Z:
I tried to register a static inner class as an IEditorDescriptionProvider for my IParameters class (using EditorFor). It didn't work. The problem is, the class is registered with the IParametersEditorMapper under its class name (Class.getName(), returned by FilterConfigurationMapper.addConfigurations), but retrieved under its canonical class name (Class.getCanonicalName(), in FilterConfigurationEditor.editConfiguration). For inner classes, these is not the same.
I can't think of any reason for using getCanonicalName, so I suggest changing it to getName. I will attach a patch against dev.
Comments (5)
-
Account Deleted -
Account Deleted Comment 2. originally posted by @ysavourel on 2013-06-29T04:04:48.000Z:
Where did you put the path Andrew? I don't see it.
Thanks. -
Account Deleted Comment 3. originally posted by and...@spartansoftwareinc.com on 2013-06-29T06:14:25.000Z:
Try again!
-
Account Deleted - changed status to resolved
Comment 4. originally posted by @ysavourel on 2013-06-29T06:33:56.000Z:
Done. I'll push it once all tests are done.
Thanks. -
Account Deleted Comment 5. originally posted by @ysavourel on 2013-06-29T06:44:34.000Z:
This issue was closed by revision fe12af5444f5.
- Log in to comment
Comment 1. originally posted by and...@spartansoftwareinc.com on 2013-06-28T21:18:21.000Z:
Patch attached. With this change, my IEditorDescriptionProvider works as expected.