XLIFF id incorrectly after rebalancing
Issue #406
open
Original issue 406 created by @ysavourel on 2014-05-23T22:03:11.000Z:
The rebalancing of the codes in fragments read from XLIFF file is dangerous, because you could get in situation where an orphan opening and an orphan closing get matches as they don't have they respective type set properly.
<trans-unit id="tu29" xml:space="preserve">
<source xml:lang="en"><it id="1" pos="open"><li></it>mouse double click event <it id="2" pos="close"></ol></it></source>
</trans-unit>
Gives: two codes matching on id=1 after rebalancing (same type='it' instead of 'li' and 'ol' in the source).
New design should fix this by a) avoiding rebalancing and b) storing the type when available.
Comments (2)
-
-
- changed status to open
make open as this would be an important refactor
- Log in to comment
I assume this issue won’t go away as long as we have the current design (new design was probably the refactor we planned that was more xliff2-like). Interested to understand how we can remove rebalance and keep the current design if its even possible.
@Chase Tingley @Mihai Nita @ysavourel