Missing ITS namespace declaration after LanguageToolStep (XLIFFWriter)

[Former user]

Original issue 430 created by @ysavourel on 2015-01-05T17:20:26.000Z:

Summary:

I'm getting back after a while on this, as I noticed something odd about the file that is generated as output of the pipeline:
[RawDocumentToFilterEventsStep > LanguageToolStep > FilterEventsToRawDocumentStep].
The output file (sample attached) uses the its xml namespace prefix in the first source element, before it is declared, thus resulting in an invalid xml file.

See https://groups.google.com/forum/#!topic/okapi-devel/7kmXpORF0ZI for the original email.

[Former user]

Comment 1. originally posted by @ysavourel on 2015-01-06T17:08:08.000Z:

I believe we encountered this issue in Ocelot and worked around it in 1.0, but then later had to change the fix because our first attempt was causing problems. I thought I'd gone back and filed this against XLIFFWriter, but apparently I forgot. Sorry!

Here's the relevant Ocelot bug (which actually describes the regression caused by our original attempt to workaround this bug): https://ocelot.atlassian.net/browse/OC-21

[Former user]

Comment 2. originally posted by @ysavourel on 2015-01-09T12:02:34.000Z:

One note: The example file is an XLIFF 1.0 file.
Technically the filter supports 1.2, not versions below. Version 1.0 files especially tend to have no namespace declaration at all and would require additional workaround.
I'll try to fix the problem focusing on 1.2 documents.

[Former user]

Comment 3. originally posted by @ysavourel on 2015-01-09T16:20:23.000Z:

This issue was closed by revision 53ad35e985c2.

[Former user]

Comment 4. originally posted by @ysavourel on 2015-01-09T16:22:00.000Z:

Limitation in the fix: you'll get duplicated version declaration if the ITS namespace is declared using a prefix different from 'its'.
It should be a very rare case.