Events that have filterParameters should also have the filterId
Issue #829
closed
This includes StartDocument
, StartSubfilter
, StartSubDocument
(and check if there are others)
There is little use to have the filter parameters if we don't know the filter.
TBD if we create a new field, or we use type
, which already exists, but is not used consistently
For instance:
- okf_properties => mimeType:text/x-properties type:text/x-properties
- okf_plaintext => mimeType:text/plain type:text/plain
- okf_html => mimeType:text/html type:null
- okf_json => mimeType:application/json type:null
Comments (7)
-
-
Done.
https://bitbucket.org/okapiframework/okapi/commits/fd98717b2e5efc28f9a85ec446a4cbd0930dece4Will be available in M38.
-
-
assigned issue to
- changed milestone to M38
-
assigned issue to
-
- changed status to resolved
-
- changed status to closed
-
- edited description
-
Added public methods:
getFilterId
andgetFilterId
https://bitbucket.org/okapiframework/okapi/commits/fd98717b2e5efc28f9a85ec446a4cbd0930dece4
- Log in to comment
Not a good idea to hijack
type
.It comes from
INameable
and is documented as <<… the type information associated with this resource. For example "button">>I propose
getFilterId
/setFilterId
(we already havegetFilterParameters
/setFilterParameters
)