Rainbow 1.39.0 fails to check for update

[Mihai Nita]

Start Rainbow 1.39.0, then go to Help => Check For Updates

Result:

Unknown application keyword.
This application is not registered in Okapi's version checking system.

Expected:

Component: rainbow
Your version: 1.39.0
Latest version: 1.39.0
Recommendation: No upgrade is needed at this time.

‌

[Mihai Nita]

The reason is the change in the Implementation-Title from rainbow to okapi-application-rainbow (from ${project.artifactId} in the pom.xml)

You can see it in the URL of the page opened by Rainbow: http://okapiframework.org/updates.html?okapi-application-rainbow=1.39.0

‌

[Mihai Nita]

TLDR: This is my fault, see https://bitbucket.org/okapiframework/okapi/commits/7ff13e3b76fa9f98751c3a4ed4130d9bee1eb28f#chg-deployment/shared/release.properties

Digging a bit in the history…

The validation happens in updates.html (source in OKAPI_ROOT/website/updates.html), which is then processed by OKAPI_ROOT/deployment/website/build.xml to generate OKAPI_ROOT/deployment/website/dist

I’ve checked Okapi versions from 0.25 to 0.38 to see how things behaved before.

Versions all the way to 0.31 (inclusive) fail with 404 because the URL is missing the .html extension (for example https://okapiframework.org/updates?okapi-lib-ui=0.30))

Between 0.32 to 0.38 the URL invoked uses updates.html, with the application name simply rainbow, not okapi-application-rainbow
(for example https://okapiframework.org/updates.html?rainbow=6.0.35))

There is also a version problem, note the 6.0.35 in the link above.

Even if we fix the rainbow vs okapi-application-rainbow difference the update check will fail because 6.0.35 < 1.39.0

So we need a fix for both.

‌

[Mihai Nita]

Proposed fix:

1. update the version check to accept both rainbow and okapi-application-rainbow and map them to the same version
2. “hack” the version check to remove the 6. prefix from the older versions

Another option would be to re-release Okapi 1.39.0 and change the Implementation-Title back to rainbow instead of bullet 1.
But I would not go this way…

‌

[Mihai Nita]

Fixed, generated a new HTML (for 1.39.0) and updated the one on FTP.

Checked with Okapi 32, 34, 36, 37, 38 and 1.39.0 (all official downloads from Bintray)

‌