Implement Visitor-like mechanism to the XLIFF document

From Martin: (original email: https://groups.google.com/forum/#!topic/okapi-devel/gPXTy6J8Zgw)

When manipulating an XLIFF2 document, I find myself iterating over the segments quite often, using this here pattern:

    for (String fileNodeID : xlf.getFileNodeIds()) {
        FileNode fileNode = xlf.getFileNode(fileNodeID);

        for (UnitNode unitNode : fileNode.getUnitNodes()) {
            Unit unit = unitNode.get();
            int segmentIndex = 0;

            for (Segment segment : unit.getSegments()) {
              // Do interesting stuff with the segment here.
              // (and its context)
              ...
              segmentIndex++
            }

It would be nice to separate the actual traversal of the XLIFF structure from the stuff that is done with the segment. So, I thought it might be possible to apply something like the visitor pattern to provide better abstraction and a clear separation of traversal and data manipulation. Each visitor class would have to have access to the context consisting of File, Unit, Segment and Segment Index. So, the pure visitor pattern might not be applicable as this context would be lost.

Comments (9)