- changed milestone to Implementer's Draft 4
Unclear definitions for requests
Sometimes we seem to forget that the same text in the spec describes not only responses, but also requests. Different rules apply to both and this is not always reflected properly.
In assurance_details
, the spec says:
txn
: REQUIRED. Identifier referring to thetxn
used in thecheck_details
. The OP MUST ensure thattxn
is present in thecheck_details
whenevidence_ref
element is used.
This should probably say assurance_details
instead of check_details
, and I guess the ‘REQUIRED’ only applies to responses?
The spec also says:
evidence_ref
: OPTIONAL. JSON array of the evidence being referred to. When present this array MUST have at least one member.
I guess this also only applies to responses?
Does it make sense to use assurance_details
at all in requests?
Comments (8)
-
-
- changed status to open
-
“The OP MUST ensure that
txn
is present in thecheck_details
whenevidence_ref
element is used.” is the correct behaviour.evidence_ref
doesn't work if thetxn
is not present incheck_details
because its using thetxn
to link theassurance_details
to the specific check done.How to use
assurance_details
in the request is described in## Requesting Verification Data
but it might be useful to include a note/link to that from the earlier section.
-
-
assigned issue to
-
assigned issue to
-
reporter After reading everything again, we might not have a problem in this regard at all. I think what I was concerned about is actually explained in Section 6. The one thing that we need to make clear, however, is that Section 5 only applies to responses, not requests.
I therefore propose to change the title of Section 5 to “Representing Verified Claims” (Section 6 is called “Requesting Verified Claims”).
-
Good plan.
-
reporter - changed status to resolved
Fix Issue
#1311, rename 'verified_claims Element' Section→ <<cset 501d6f5c6c4f>>
-
Merged in danielfett/fix-1311 (pull request #126)
Fix Issue
#1311, rename 'verified_claims Element' SectionApproved-by: Mark Haine Approved-by: Kai Lehmann Approved-by: Joseph Heenan
→ <<cset dc290ca9063f>>
- Log in to comment