Duplicate study code in dx.py doesn't work
In implementing the event level SOPInstanceUID for dx.py
(issue #610), it has become clear that the code for dealing with multiple studies with the same study instance UID does not function.
This was partially fixed in 6cda0df, but in attempting to test that fix I have realised that the function drops out even before it gets to that code.
This aught to be fixed...
Comments (17)
-
reporter -
reporter Reverted sample local_settings. Added explicit setting of log level for each log capture. Refs
#610,#628→ <<cset 5259c6b09128>>
-
reporter Adding a sed regex to replace all Info levels with Debug in local settings. Sledgehammer... Refs
#610,#628Also removed pip list.→ <<cset 502919e5c20c>>
-
reporter Adding the mod to set the logging level to debug for all the testing. Refs
#610,#628→ <<cset 5b83dff4a34d>>
-
reporter Refactored _create_event into separate module so I don't have to re-code it for mammo. Works for DX, haven't started modifying for mammo yet. Refs
#610,#628→ <<cset 3cb339f36eb9>>
-
reporter Substituted each logging message 'DX' with modality. Added requirement to check object is not the secondary capture Hologic object.. Refs
#610,#628→ <<cset d038e4b4f940>>
-
reporter Rename image_import_create_event to get_study_check_dup. Removed _create_event from each module. Set mam to use the new function. Refs
#610,#628→ <<cset 61ca11fe05f9>>
-
reporter Adding test files to enable testing of mammo import with duplicates etc. Started on tests. Refs
#610,#628→ <<cset ac0249a123c6>>
-
reporter Removed try except and corrected an error it was hiding. Initial test works. Refs
#610,#628→ <<cset bba06fddc29f>>
-
reporter Explicitly named mam log for consistency. Added record_sop for new studies. Added tests for importing new event and duplicate vent a second time. Lots of duplication still... for another time! Refs
#610,#628→ <<cset 3bf064fa0fa6>>
-
reporter Fixing minor codacy issue. Refs
#610,#628→ <<cset 26f0f8eadf5a>>
-
reporter Fixing import issue in test flagged by @dplatten's codacy integration. Refs
#610,#628→ <<cset 5edb87d524b1>>
-
reporter Adding ref
#628to changes. Ref#610is already there.→ <<cset 594e6746ee03>>
-
reporter - changed status to resolved
Merged in issue610duplicatesagain (pull request #193)
Issue610duplicatesagain
→ <<cset 9162ebc7d1ba>>
-
reporter Tested in production. check_uid.check_uid was preventing UIDs to be collected, and isn't needed in extract_common. Removed. Added debug logging to duplicates QR code. Added query stage updates for web interface. Refs
#610,#628→ <<cset 05e0457273b4>>
-
reporter Updated test due to duplicate message appearing at different point after removing check_uid.check_uid use. Refs
#610,#628→ <<cset 381e8aec20ca>>
-
reporter Modifying interface duplicates help text as we are not using study instance UID as the duplicate marker. Refs
#610,#628. [skip ci]→ <<cset b335851ad132>>
- Log in to comment
Fixed image import when more than one existing study in the database matches the new image study UID. Refs
#628. Added tests that helped to fix the function.→ <<cset 06ac2c50305c>>