Accession number and patient ID should export as text
Numeric accession numbers and Patient ID fields should be treated as strings on export, not converted to numbers. This would for example prevent leading zeros from being removed.
Issue reported to Google group by @LuukO.
Comments (26)
-
reporter -
reporter Adding try except around int conversion - return_for_export might return None. Refs
#443→ <<cset b2cb482ebf42>>
-
reporter Moved _to_float to tools, renamed, tightened up except clause. Minor formatting. Refs
#443→ <<cset e1939e593100>>
-
reporter Adding CT GE Optima CT660 RDSR for automated testing against. Refs
#427and will be useful for testing ref#443→ <<cset a5cac1383338>>
-
reporter Start of tests for CT exports. Refs
#427,#443→ <<cset ba2c89e9d1e4>>
-
reporter Modified ctxlsx to allow exports when not using Celery. Fixed mistake in assert. Test fails, as expected. Refs
#427,#443→ <<cset d42359a316ed>>
-
reporter Added the remaining tests for the CT xlsx export to check against ref
#443export of ID and accession number as text. Should pass!→ <<cset 0f4a62e215db>>
-
reporter Set xlsxwriter to use date format as set in settings.py or overridden in local_settings.py. Refs
#443→ <<cset 3e0adcab0e8a>>
-
reporter Adding stubs into the docs referring to the new date settings. Refs
#443→ <<cset 2596f12207fd>>
-
reporter Adding GE XR220 mobile DX images for testing, initially for ref
#443→ <<cset 1fadd025e6d5>>
-
reporter Basis for dx tests, initially refs
#443→ <<cset 14e1d37ed811>>
-
reporter Added task ID creation for testing.Setting the test data for checking DX against ref
#443→ <<cset e7899d8ba79f>>
-
reporter Added a test to make sure that numbers remain as numbers after fixes that ref
#443→ <<cset f0e282b2b013>>
-
reporter Set date format for dx xlsx from settings. Now using xlrd to test value types and values. Pandas too keen to convert to numbers so testing ineffective! Fails against patient ID as currently number. Refs
#443. Need to redo tests for CT with xlrd.→ <<cset 12ef2c817750>>
-
reporter Patient ID and accession number now correctly text, but fails on exposure index not being a number. Refs
#443→ <<cset cdeb7285cbde>>
-
reporter Converted all the numbers to numbers. DX xlsx now fixed for ref
#443, but could do with some major refactoring!→ <<cset 4c049664d546>>
-
reporter CT export to xlsx now tested for ref
#443using xlrd instead of pandas. Need to check rf next.→ <<cset c2066c62051f>>
-
reporter Adding RF Zee file for testing ref
#443→ <<cset 706d73ed3847>>
-
reporter Initial commit of rf xlsx export test code copied from DX. Refs
#443→ <<cset 6d47d2327fbf>>
-
reporter Set date variable. Now accession number and ID are strings, but so are numbers. Refs
#443→ <<cset ce1571a4b847>>
-
reporter Set strings to strings and numbers to numbers. Refs
#443→ <<cset c5a0bfc3190c>>
-
reporter - changed status to resolved
All xlsx exports now exporting ID and Accession number as text, fixes
#443→ <<cset 2fcaa731f0f0>>
-
reporter -
assigned issue to
-
assigned issue to
-
reporter Adding ref
#443to changes/CHANGES→ <<cset cffcad8c241d>>
-
reporter Forgot to re-comment the test file delete lines. Refs
#443→ <<cset eb16f8a3a2f6>>
-
Accepts varic dose report. Refs
#443→ <<cset 61a89712e941>>
- Log in to comment
Changes as made by @LuukO. It would be good to remember why I made all the numbers into strings in the first place! Needs further review and testing. Changes should be made to all xlsx exports accordingly. Refs
#443→ <<cset 6aa02277a4ae>>