Orthanc script zip command doesn't work for linux

[Ed McDonagh]

Because the path is quoted, the * will not be expanded and the command fails.

This command works:

local zip_executable = '/usr/bin/zip -r'

-- Zip the study files to save space and remove the originals after zipping
print('Zipping physics images: ' .. zip_executable .. ' "' .. temp_files_path .. '.zip"' .. ' "' .. temp_files_path .. dir_sep .. '"')
os.execute(zip_executable .. ' "' .. temp_files_path .. '.zip"' .. ' "' .. temp_files_path .. dir_sep .. '"')

i.e. I've removed the *.dcm at the end - the -r will recurse into the directory and scoop everything up.

Obviously we need it to continue to work for Windows.

@dplatten - can you advise?

[David Platten]

@edmcdonagh, the -r switch also works for 7zip on Windows. So we can use your suggested os.execute, but with a Windows command like:

local zip_executable = 'D:\\Server Apps\\7zip\\7za.exe a -r'

[David Platten]

I'll commit these changes to develop.

[Ed McDonagh]

Thanks David

[David Platten]

This is fixed in commit #a26d913

[David Platten]

Updated changes files. References issue #674

→ <<cset 5f3466b4a321>>

[Ed McDonagh]

Can we keep things open until they are merged in, else I lose them

[Ed McDonagh]

I see, you didn't branch. Tut tut.

[David Platten]

Apologies - I'll consider my knuckles rapped.