Add tests for high total dose at RP and total DAP alerts for fluoroscopy

[David Platten]

I'd like these tests to be present before this code is released.

Need to test:

• Total DAP flags when above alert level
• Total dose at RP flags when above alert level
• Cumulative DAP over time delta is correct, and flags when above alert level
• Cumulative total dose at RP over time delta is correct, and flags when above alert level
• For single- and bi-planar?

[David Platten]

Adding tests for RF high dose alerts. Incomplete and not totally working yet - pipelines will fail [skip ci]. References issue #697

→ <<cset 0e8f1ee6542b>>

[David Platten]

Tests for correct cumulated DAP and dose at RP; tests for correct highlighting of cumulated and non-cumulated DAP and dose at RP. References issue #697

→ <<cset eb6dc86d0953>>

[David Platten]

@edmcdonagh do you have a bi-planar fluoroscopy RDSR that can be added to the tests folder? I'd like to include a test on this.

[David Platten]

I should also add some tests to confirm that the highlighting works in the rf_detail_view

[Ed McDonagh]

I don't have a biplane fluoro RDSR we can use - the only one I have is way too large. We could put out a request on the group? My cath labs that have RDSR are single plane so I can't generate one myself.

Also, the last merge I did makes changes to the rfdetail.html template, just so you are aware...

[David Platten]

I like the removal of JavaScript toPrecision(). I'll sync my test branch shortly and amend the test code.

[David Platten]

Added tests for the RF detail view. References issue #697

→ <<cset 2bd218371d5b>>

[David Platten]

Amended tests after merge of develop that has removed the JavaScript toPrecision function. References issue #697

→ <<cset 9a4cbc3be457>>

[David Platten]

Moved check strings into self to avoid multiple declarations. References issue #697

→ <<cset efebf3349bc7>>

[David Platten]

I'd just like to add some bi-planar tests, then this is done.

[David Platten]

@edmcdonagh we could merge in this branch, and then create a new issue for adding bi-planar tests.

[Ed McDonagh]

Happy with that.

[David Platten]

Updating changes files [skip ci]. References issue #697

→ <<cset 8c4c1f6df156>>

[David Platten]

Merged in issue697testsForHighDoseFluoroAlerts (pull request #252)

Issue697testsForHighDoseFluoroAlerts

Approved-by: David Platten [e-mail]

Fixes issue #697

→ <<cset b85b42cf57c4>>

[Ed McDonagh]

Hi @dplatten

I'm getting failures on my local system with line 250 getting three red 0.00252 strings instead of one. Seems ok on bitbucket. Any ideas?

[Ed McDonagh]

See below for a screenshot of the html created by the test:

[David Platten]

OK. I've worked out what's going on. My assumption was that when the two RDSRs are imported by the test routine that they would have specific private keys that would be the same for all of the tests. This is not the case (the "Warning! That study was not found" in your html above made me check). When the test routine reaches the point that you had the problem the pks were 7 and 8 for the two studies.

I need to change the tests so that I obtain the appropriate private key for the study I want to test by filtering GeneralStudyModuleAttr, rather than assuming that the private keys are fixed values.

This reopens #697.

[David Platten]

Need to improve test routines so that the correct private keys are used for tests on specific studies.

[Ed McDonagh]

Thanks David.

[David Platten]

Explicitly obtaining private keys of the two test studies rather than making assumptions about what the private keys might be. This only matters for tests involving the detail view; the summary view shows both studies. References issue #697

→ <<cset 56a5db09e9ee>>

[David Platten]

Merged in issue697improveFluoroHighDoseAlertTests (pull request #257)

Explicitly obtaining private keys of the two test studies rather than making assumptions about what the private keys might be. This only matters for tests involving the detail view; the summary view shows both studies. References issue #697

Approved-by: Ed McDonagh [e-mail]

Fixes issue #697

→ <<cset dd5bc7a39c46>>

[David Platten]

Merged in issue697improveFluoroHighDoseAlertTests (pull request #257)

Explicitly obtaining private keys of the two test studies rather than making assumptions about what the private keys might be. This only matters for tests involving the detail view; the summary view shows both studies. References issue #697

Approved-by: Ed McDonagh [e-mail]

Fixes issue #697

→ <<cset dd5bc7a39c46>>

[David Platten]

Added language override to the fluoro high dose alert tests. The tests now work regardless of the language code set in local_settings.py. References issue #665 and issue #697

→ <<cset 64c258f20b69>>

[David Platten]

Merged in issue697fluoroHighDoseTestsLanguageSetting (pull request #258)

Added language override to the fluoro high dose alert tests. The tests now work regardless of the language code set in local_settings.py. References issue #665 and issue #697

Approved-by: David Platten [e-mail] Approved-by: Ed McDonagh [e-mail]

References issue #665 and issue #697, both of which are closed already.

→ <<cset 07a6d38308d7>>

[David Platten]

Merged in issue697fluoroHighDoseTestsLanguageSetting (pull request #258)

Added language override to the fluoro high dose alert tests. The tests now work regardless of the language code set in local_settings.py. References issue #665 and issue #697

Approved-by: David Platten [e-mail] Approved-by: Ed McDonagh [e-mail]

References issue #665 and issue #697, both of which are closed already.

→ <<cset 07a6d38308d7>>

[David Platten]

Issue #687 was marked as a duplicate of this issue.